Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sample): Update parallel append sample to use StreamWriterV2 #883

Merged
merged 6 commits into from
Feb 25, 2021

Conversation

yayi-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yayi-google yayi-google requested a review from a team February 24, 2021 22:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 24, 2021
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Feb 24, 2021
@yayi-google yayi-google requested a review from yirutang February 24, 2021 22:58
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 24, 2021
Copy link

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see region tags anywhere and you appear to have added a example w/o a test.

  • You should consider adding an IT test before committing.
  • You should consider adding region tags before committing.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #883 (8a7da6d) into master (8e2ab01) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #883   +/-   ##
=========================================
  Coverage     80.85%   80.85%           
  Complexity     1014     1014           
=========================================
  Files            76       76           
  Lines          5500     5500           
  Branches        423      423           
=========================================
  Hits           4447     4447           
  Misses          880      880           
  Partials        173      173           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e2ab01...8a7da6d. Read the comment docs.

@yayi-google
Copy link
Contributor Author

I don't see region tags anywhere and you appear to have added a example w/o a test.

  • You should consider adding an IT test before committing.
  • You should consider adding region tags before committing.

We have IT test in the test fold.
We have region tags at the line 19.

@lesv
Copy link

lesv commented Feb 25, 2021

Sg - that's why I gave a LGTM - I just have to ask. L19 wasn't shown in the PR

@stephaniewang526 stephaniewang526 merged commit 5c5c690 into master Feb 25, 2021
@stephaniewang526 stephaniewang526 deleted the migrate-sample branch February 25, 2021 14:17
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…Modificatio… (googleapis#883)

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
🤖 I have created a release *beep* *boop*
---


### [0.123.28](googleapis/java-storage-nio@v0.123.27...v0.123.28) (2022-04-18)


### Bug Fixes

* **native:** initialize classes at build-time to fix Native Image compilation ([googleapis#874](googleapis/java-storage-nio#874)) ([df905cb](googleapis/java-storage-nio@df905cb))
* **test:** replace HashMap with ConcurrentHashMap to avoid ConcurrentModificatio… ([googleapis#883](googleapis/java-storage-nio#883)) ([d2fe2a0](googleapis/java-storage-nio@d2fe2a0))


### Dependencies

* update dependency com.google.apis:google-api-services-storage to v1-rev20220401-1.32.1 ([googleapis#881](googleapis/java-storage-nio#881)) ([a598199](googleapis/java-storage-nio@a598199))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([googleapis#884](googleapis/java-storage-nio#884)) ([c08f115](googleapis/java-storage-nio@c08f115))
* update dependency com.google.cloud:google-cloud-storage to v2.6.0 ([googleapis#878](googleapis/java-storage-nio#878)) ([0bd1985](googleapis/java-storage-nio@0bd1985))
* update dependency com.google.cloud:google-cloud-storage to v2.6.1 ([googleapis#885](googleapis/java-storage-nio#885)) ([cf24525](googleapis/java-storage-nio@cf24525))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants