-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(sample): Update parallel append sample to use StreamWriterV2 #883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see region tags anywhere and you appear to have added a example w/o a test.
- You should consider adding an IT test before committing.
- You should consider adding region tags before committing.
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
=========================================
Coverage 80.85% 80.85%
Complexity 1014 1014
=========================================
Files 76 76
Lines 5500 5500
Branches 423 423
=========================================
Hits 4447 4447
Misses 880 880
Partials 173 173 Continue to review full report at Codecov.
|
We have IT test in the test fold. |
Sg - that's why I gave a LGTM - I just have to ask. L19 wasn't shown in the PR |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.12.0](https://www.github.com/googleapis/java-bigquerystorage/compare/v1.11.0...v1.12.0) (2021-02-25) ### Features * StreamWriterV2 sets exception for response with error ([#884](https://www.github.com/googleapis/java-bigquerystorage/issues/884)) ([4677d7b](https://www.github.com/googleapis/java-bigquerystorage/commit/4677d7bd56db6c76106daeb7be38fa65f1c9c745)) ### Documentation * **sample:** Update parallel append sample to use StreamWriterV2 ([#883](https://www.github.com/googleapis/java-bigquerystorage/issues/883)) ([5c5c690](https://www.github.com/googleapis/java-bigquerystorage/commit/5c5c690fe39b3055596712dbd39064aed0b023da)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…Modificatio… (googleapis#883) Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ### [0.123.28](googleapis/java-storage-nio@v0.123.27...v0.123.28) (2022-04-18) ### Bug Fixes * **native:** initialize classes at build-time to fix Native Image compilation ([googleapis#874](googleapis/java-storage-nio#874)) ([df905cb](googleapis/java-storage-nio@df905cb)) * **test:** replace HashMap with ConcurrentHashMap to avoid ConcurrentModificatio… ([googleapis#883](googleapis/java-storage-nio#883)) ([d2fe2a0](googleapis/java-storage-nio@d2fe2a0)) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20220401-1.32.1 ([googleapis#881](googleapis/java-storage-nio#881)) ([a598199](googleapis/java-storage-nio@a598199)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([googleapis#884](googleapis/java-storage-nio#884)) ([c08f115](googleapis/java-storage-nio@c08f115)) * update dependency com.google.cloud:google-cloud-storage to v2.6.0 ([googleapis#878](googleapis/java-storage-nio#878)) ([0bd1985](googleapis/java-storage-nio@0bd1985)) * update dependency com.google.cloud:google-cloud-storage to v2.6.1 ([googleapis#885](googleapis/java-storage-nio#885)) ([cf24525](googleapis/java-storage-nio@cf24525)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️