Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BigDecimal and ByteString encoding #971

Merged

Conversation

JacobStocklass
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@JacobStocklass JacobStocklass requested review from a team and shollyman March 29, 2021 21:48
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Mar 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #971 (20ff9e1) into master (9bc1a4b) will decrease coverage by 0.05%.
The diff coverage is 68.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #971      +/-   ##
============================================
- Coverage     81.05%   80.99%   -0.06%     
- Complexity     1038     1043       +5     
============================================
  Files            77       78       +1     
  Lines          5632     5657      +25     
  Branches        431      433       +2     
============================================
+ Hits           4565     4582      +17     
- Misses          884      889       +5     
- Partials        183      186       +3     
Impacted Files Coverage Δ Complexity Δ
...y/storage/v1beta2/BigDecimalByteStringEncoder.java 68.00% <68.00%> (ø) 5.00 <5.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc1a4b...20ff9e1. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 82b556e into googleapis:master Mar 30, 2021
@JacobStocklass JacobStocklass deleted the jstocklass-BigDecimal branch March 30, 2021 16:31
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants