feat: temp workaround for omg/48020 #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquerystorage
yirutang
changed the title
yirutang
changed the title
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gnanda
reviewed
Feb 8, 2022
| * @param reconnectOnStuck | ||
| * @return Builder | ||
| */ | ||
| public Builder setReconnectOnStuck(boolean reconnectOnStuck) { |
There was a problem hiding this comment.
Can we rename this to something less pleasant so no one enables it by accident? For example if the omg numbers are public, can we embed that in the name of the method?
There was a problem hiding this comment.
O yeah. how about ReconnectAfter10M?
all errors should fail.
gnanda
approved these changes
Feb 8, 2022
...e/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryWriteManualClientTest.java
Show resolved
Hide resolved
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
stephaniewang526
approved these changes
Feb 8, 2022
stephaniewang526
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.4...v2.9.0) (2022-02-08) ### Features * add a indicator of how much time a request is waiting for inflight limit ([#1514](#1514)) ([54874be](54874be)) * temp workaround for omg/48020 ([#1521](#1521)) ([ff28f65](ff28f65)) ### Bug Fixes * add a DATE type e2e test ([#1511](#1511)) ([5eaf38e](5eaf38e)) ### Documentation * **tutorials:** Add IT to JsonWriteDefaultStream tutorial ([#1522](#1522)) ([9fd7aca](9fd7aca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be used by customer who is affected by omg/48020 (connection stuck after 10MB) using JsonWriter directly, before fix finished rolling out on Friday 2/11. It can be enabled by calling JsonWriter.setReconnectOnStuck(true).
The write performance will be impacted by this change, but it can work around the stuckness.