Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Incorrect change from gapic in MockBigQueryWriteImpl #192

Closed
wants to merge 1 commit into from
+3 −4
Closed

[DO NOT MERGE] Incorrect change from gapic in MockBigQueryWriteImpl #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>4.4.1</version>
<version>5.1.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
3 changes: 1 addition & 2 deletions ...orage/src/test/java/com/google/cloud/bigquery/storage/v1alpha2/MockBigQueryWriteImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,11 @@ public void createWriteStream(
@Override
public StreamObserver<AppendRowsRequest> appendRows(
final StreamObserver<AppendRowsResponse> responseObserver) {
final Object response = responses.remove();
StreamObserver<AppendRowsRequest> requestObserver =
new StreamObserver<AppendRowsRequest>() {
@Override
public void onNext(AppendRowsRequest value) {
requests.add(value);
final Object response = responses.remove();
if (response instanceof AppendRowsResponse) {
responseObserver.onNext((AppendRowsResponse) response);
} else if (response instanceof Exception) {
Expand Down
2 changes: 1 addition & 1 deletion synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"git": {
"name": ".",
"remote": "https://github.com/googleapis/java-bigquerystorage.git",
"sha": "a0db93e9d1f714a68dd11ef38c782099701dd068"
"sha": "532a698193542b0a5db03d2e29a415082f2de95b"
}
},
{
Expand Down