Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable tests that are disabled due to breaking change and stop ignoring ALREADY_EXISTED error #748

Merged
merged 14 commits into from
Dec 21, 2020

Conversation

yirutang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested review from a team and pmakani December 18, 2020 19:52
@product-auto-label product-auto-label bot added the api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. label Dec 18, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 18, 2020
@yirutang yirutang changed the title fix: enable tests that are disabled due to breaking change fix: enable tests that are disabled due to breaking change and stop ignoring ALREADY_EXISTED error Dec 18, 2020
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #748 (1ec0d35) into master (248ab73) will increase coverage by 0.08%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #748      +/-   ##
============================================
+ Coverage     80.72%   80.80%   +0.08%     
  Complexity      985      985              
============================================
  Files            73       73              
  Lines          5271     5289      +18     
  Branches        402      406       +4     
============================================
+ Hits           4255     4274      +19     
+ Misses          847      845       -2     
- Partials        169      170       +1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 85.08% <91.66%> (+0.84%) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248ab73...1ec0d35. Read the comment docs.

@stephaniewang526 stephaniewang526 added the automerge Merge the pull request once unit tests and other checks pass. label Dec 21, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8caf5a2 into googleapis:master Dec 21, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 21, 2020
@yirutang yirutang deleted the enable-test branch February 18, 2021 00:10
shubhwip pushed a commit to shubhwip/java-bigquerystorage that referenced this pull request Oct 7, 2023
…onfig to v1.2.0 (googleapis#748)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://github.com/googleapis/java-shared-config) | `1.1.0` -> `1.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.0/compatibility-slim/1.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.0/confidence-slim/1.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.2.0`](https://github.com/googleapis/java-shared-config/blob/master/CHANGELOG.md#&#8203;120-httpswwwgithubcomgoogleapisjava-shared-configcomparev110v120-2021-10-21)

[Compare Source](https://github.com/googleapis/java-shared-config/compare/v1.1.0...v1.2.0)

##### Features

-   Introduce Native Image testing build script changes ([#&#8203;1240](https://www.github.com/googleapis/java-shared-config/issues/1240)) ([#&#8203;334](https://www.github.com/googleapis/java-shared-config/issues/334)) ([4643cf1](https://www.github.com/googleapis/java-shared-config/commit/4643cf15be0b37fa8fa905d544d438cda7ef2ecd))

##### Bug Fixes

-   **java:** downgrade native maven plugin version ([#&#8203;335](https://www.github.com/googleapis/java-shared-config/issues/335)) ([5834284](https://www.github.com/googleapis/java-shared-config/commit/5834284176fb34713d10082ce04f3b6abba85ad8))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-storage-nio).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants