-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): adopt flatten plugin and google-cloud-shared-dependencies #350
Conversation
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
============================================
- Coverage 80.26% 80.24% -0.02%
Complexity 1102 1102
============================================
Files 105 105
Lines 6815 6815
Branches 364 364
============================================
- Hits 5470 5469 -1
- Misses 1146 1148 +2
+ Partials 199 198 -1
Continue to review full report at Codecov.
|
Please attach a diff of how the dependencies change for end users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will review once looking at diff
@igorbernstein2 there is no change in dependency list for end users -- i added a kokoro check for this in dependencies.sh to ensure accuracy. The only difference is that transitive dependencies are resolved to be direct. i will share my doc with you for further details. Thanks. |
Looking at the main artifact, the proposed change will affect the following deps (by pulling them up to the top level).
This means that those libraries might change version in customer applications if bigtable was tied for a version. But I dont see any tangible negative effects that this would have. I think we can probably merge |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.15.0](https://www.github.com/googleapis/java-bigtable/compare/v1.14.0...v1.15.0) (2020-09-01) ### Features * extend channel priming logic to also send fake requests ([#398](https://www.github.com/googleapis/java-bigtable/issues/398)) ([6f1ead2](https://www.github.com/googleapis/java-bigtable/commit/6f1ead2097150a87cb9712bcf35c6eaa9d57440c)) * **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#350](https://www.github.com/googleapis/java-bigtable/issues/350)) ([2298596](https://www.github.com/googleapis/java-bigtable/commit/2298596dab8a1ef87c0f48d3abe8bc3955417eb1)) ### Bug Fixes * temporarily disable reporting to unblock releases ([#395](https://www.github.com/googleapis/java-bigtable/issues/395)) ([a56a0f8](https://www.github.com/googleapis/java-bigtable/commit/a56a0f8c9caf675b68d02587b042e1feeb261ccb)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#377](https://www.github.com/googleapis/java-bigtable/issues/377)) ([bdae336](https://www.github.com/googleapis/java-bigtable/commit/bdae336074d80815dcaaf8c71befafc0ed66c079)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.0 ([#402](https://www.github.com/googleapis/java-bigtable/issues/402)) ([08f7d84](https://www.github.com/googleapis/java-bigtable/commit/08f7d84333c6a74bf03e0a57707b878a29400dd4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
No description provided.