Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back in extraFiles and fix file path #833

Merged
merged 1 commit into from
May 20, 2021

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented May 20, 2021

file path was removed in last sp merge. It was pointing to the wrong file

- google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/ClientVersion.java

@kolea2 kolea2 requested review from a team as code owners May 20, 2021 21:25
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .github/release-please.yml

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label May 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@kolea2 kolea2 merged commit f914954 into googleapis:master May 20, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 20, 2021
@kolea2 kolea2 deleted the client-version-fix branch May 20, 2021 21:41
kolea2 added a commit to kolea2/java-bigtable that referenced this pull request May 20, 2021
kolea2 added a commit that referenced this pull request May 21, 2021
* chore: improve embedded version handling (#715)

* chore: improve embedded version handling

Use new feature in releasetool (googleapis/releasetool#317) to manage the client version instead of maven tricks introduced in #451

* migrate to new version scheme

* rename back to Version

* config release-please for version bumps

* make sure file doesnt get clobbered

* add a couple of tests

* fmt

(cherry picked from commit 1af8925)

* update version

* fix test

* fix: add back in extraFiles and fix file path (#833)

(cherry picked from commit f914954)

* fix test

Co-authored-by: Igor Bernstein <igorbernstein@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants