Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: temporary fix for the BOM assertion logic #5913

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Apr 4, 2023

There's another check that verifies the existence of the BOM entries.

Without this workaround, the check fails in the release pull request: #5891 (comment)

@suztomo suztomo requested a review from a team as a code owner April 4, 2023 21:19
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 4, 2023
@JoeWang1127
Copy link
Contributor

Do we still need this since googleapis/google-cloud-java#9304 is resolved?

@suztomo
Copy link
Member Author

suztomo commented Apr 4, 2023

@JoeWang1127 The fix has not been released. The latest gapic-libraries-bom used here has invalid entries.

@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Apr 4, 2023
@ddixit14 ddixit14 merged commit 4ff2aca into googleapis:main Apr 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 4, 2023
@suztomo suztomo deleted the temporary_fix_bom_content_test branch April 4, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants