-
Notifications
You must be signed in to change notification settings - Fork 39
Increase DEFAULT_CHUNK_SIZE to reduce transfer overhead #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this breaks com.google.cloud.BaseWriteChannelTest
7303d92
to
6f0abcd
Compare
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
============================================
+ Coverage 66.32% 66.46% +0.14%
+ Complexity 367 362 -5
============================================
Files 34 34
Lines 1865 1858 -7
Branches 236 234 -2
============================================
- Hits 1237 1235 -2
+ Misses 526 521 -5
Partials 102 102
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @domZippilli!
Hey just wanted to check in -- are there any steps I need to take to move this forward? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frankyn FYI, you need to select the approve button in Github. Unlike google3, LGTM in a comment doesn't suffice.
I did approve, but my approval doesn't count IIUC. Also I can't merge, could you help merge the PR as well @elharo? |
Fixes #86 by setting the DEFAULT_CHUNK_SIZE to 15MiB.