Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make toPb methods public #1007

Open
frekw opened this issue Mar 2, 2023 · 0 comments · May be fixed by #1196
Open

Make toPb methods public #1007

frekw opened this issue Mar 2, 2023 · 0 comments · May be fixed by #1196
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frekw
Copy link

frekw commented Mar 2, 2023

Is your feature request related to a problem? Please describe.
In a similar vein as #1006, there are situations where it would be very useful to convert from com.google.cloud.datastore.Entity to com.google.datastore.v1.Entity.

Describe the solution you'd like
Make toPb public.

Describe alternatives you've considered
I currently have interop packages of my own living in com.google.datastore that re-export these methods. It works but isn't great.
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Mar 2, 2023
@meredithslota meredithslota added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 7, 2023
@TurtleBeatboxer TurtleBeatboxer linked a pull request Sep 23, 2023 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: All toPb() methods access level changed to public TurtleBeatboxer/java-datastore
2 participants
@frekw @meredithslota