Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark AggregationResult#get with ObsoleteApi annotation #1175

Closed
jainsahab opened this issue Aug 23, 2023 · 0 comments · Fixed by #1185
Closed

Mark AggregationResult#get with ObsoleteApi annotation #1175

jainsahab opened this issue Aug 23, 2023 · 0 comments · Fixed by #1185
Assignees
Labels
api: datastore Issues related to the googleapis/java-datastore API. documentation Improvements or additions to documentation

Comments

@jainsahab
Copy link
Contributor

jainsahab commented Aug 23, 2023

Context: With the introduction of SUM And AVG aggregation, we have exposed two new methods AggregationResult#getLong(String) and AggregationResult#getDouble(String) as the existing method Long AggregationResult#get was not enough for the cases where we get an aggregation result of Double type (like in SUM and AVG aggregation). Now users can call the respective methods (getXXX) based on the type of aggregation results they are expecting.

Action Item: Once ObsoleteApi annotation is released and ready to use, mark AggregationResult#get with it.

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Aug 23, 2023
@jainsahab jainsahab self-assigned this Aug 23, 2023
@jainsahab jainsahab added documentation Improvements or additions to documentation api: datastore Issues related to the googleapis/java-datastore API. and removed api: datastore Issues related to the googleapis/java-datastore API. labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant