Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address TODOs related to gapic_upgrade #1242

Open
jainsahab opened this issue Nov 22, 2023 · 2 comments
Open

address TODOs related to gapic_upgrade #1242

jainsahab opened this issue Nov 22, 2023 · 2 comments
Assignees
@cindy-peng
Labels
api: datastore Issues related to the googleapis/java-datastore API. type: cleanup An internal cleanup or hygiene concern.

Comments

@jainsahab
Copy link
Contributor

Address all the TODOs related to gapic upgrade, search for TODO(gapic_upgrade) in code.
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Nov 22, 2023
@jainsahab jainsahab self-assigned this Nov 22, 2023
@jainsahab jainsahab mentioned this issue Nov 22, 2023
Merged
@jainsahab jainsahab assigned kolea2 and unassigned jainsahab Dec 7, 2023
@kolea2
Copy link
Collaborator

kolea2 commented Feb 6, 2024

#1299 remove checks around emulator

@kolea2 kolea2 mentioned this issue Feb 6, 2024
Merged
@kolea2 kolea2 added the type: cleanup An internal cleanup or hygiene concern. label Feb 23, 2024
@kolea2 kolea2 assigned cindy-peng and unassigned kolea2 Jun 3, 2024
@cindy-peng
Copy link
Contributor

Related issue: #1557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindy-peng cindy-peng

Labels
api: datastore Issues related to the googleapis/java-datastore API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jainsahab @kolea2 @cindy-peng