Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Try-with-resources in Datastore samples #1248

Open
jainsahab opened this issue Nov 30, 2023 · 0 comments
Open

Use Try-with-resources in Datastore samples #1248

jainsahab opened this issue Nov 30, 2023 · 0 comments
Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@jainsahab
Copy link
Contributor

In #1246 Datastore instance holds resources which needs to be closed, For this reason we need to update all samples with try-with-resources
@product-auto-label product-auto-label bot added api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. labels Nov 30, 2023
@jainsahab jainsahab mentioned this issue Nov 30, 2023
Merged
@kolea2 kolea2 added the type: cleanup An internal cleanup or hygiene concern. label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jainsahab @kolea2