Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: expose DNSSEC options of ManagedZones #276

Merged
merged 4 commits into from
Dec 28, 2020
Merged

feat: expose DNSSEC options of ManagedZones #276

merged 4 commits into from
Dec 28, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Dec 9, 2020

Fixes #273

@athakor athakor requested a review from a team as a code owner December 9, 2020 16:31
@product-auto-label product-auto-label bot added the api: dns Issues related to the googleapis/java-dns API. label Dec 9, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2020
@athakor athakor requested a review from chingor13 December 9, 2020 16:32
@codecov
Copy link

codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #276 (8bd2f56) into master (3bce911) will decrease coverage by 0.79%.
The diff coverage is 70.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
- Coverage     78.13%   77.34%   -0.80%     
- Complexity      172      175       +3     
============================================
  Files            15       15              
  Lines          1052     1174     +122     
  Branches         83      101      +18     
============================================
+ Hits            822      908      +86     
- Misses          192      215      +23     
- Partials         38       51      +13
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/google/cloud/dns/Zone.java 80.85% <0.00%> (-3.60%) 15.00 <0.00> (ø)
src/main/java/com/google/cloud/dns/ZoneInfo.java 81.90% <71.42%> (-13.70%) 29.00 <1.00> (+3.00) ⬇️
src/main/java/com/google/cloud/dns/Dns.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bce911...8bd2f56. Read the comment docs.

@athakor
Copy link
Contributor Author

athakor commented Dec 11, 2020

@chingor13 PTAL

@chingor13 chingor13 merged commit b3bdbd1 into googleapis:master Dec 28, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 22, 2021
@release-please
chore(master): release 1.1.0 (#310)
5d4e137 
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.1.0](https://www.github.com/googleapis/java-dns/compare/v1.0.8...v1.1.0) (2021-02-22)


### Features

* add supports of labels while creating managed zone ([#289](https://www.github.com/googleapis/java-dns/issues/289)) ([47b687f](https://www.github.com/googleapis/java-dns/commit/47b687f2aeadc25f24c0c9401be8062b87527580))
* expose DNSSEC options of ManagedZones ([#276](https://www.github.com/googleapis/java-dns/issues/276)) ([b3bdbd1](https://www.github.com/googleapis/java-dns/commit/b3bdbd1f9e1e593264908dcc913866c5876e1197))


### Bug Fixes

* don't log downloads ([#318](https://www.github.com/googleapis/java-dns/issues/318)) ([0b7cb06](https://www.github.com/googleapis/java-dns/commit/0b7cb06e30a8cd9e413375961701952acdb87e5e))
* update repo name ([#312](https://www.github.com/googleapis/java-dns/issues/312)) ([83cbd61](https://www.github.com/googleapis/java-dns/commit/83cbd610763b5010c9748094cbb8e3dbaceec11c))


### Dependencies

* update dependency com.google.apis:google-api-services-dns to v1-rev20210204-1.31.0 ([#315](https://www.github.com/googleapis/java-dns/issues/315)) ([29f0414](https://www.github.com/googleapis/java-dns/commit/29f0414b91b8922c87dbfe47ed7ea9ca3f8e0c90))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.18.0 ([#298](https://www.github.com/googleapis/java-dns/issues/298)) ([7da3244](https://www.github.com/googleapis/java-dns/commit/7da324461b3848acc66af7efbb827422a456ebdd))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.19.0 ([#319](https://www.github.com/googleapis/java-dns/issues/319)) ([e2da544](https://www.github.com/googleapis/java-dns/commit/e2da544fdd62017f21fc78e93dcfa296e83829fa))
* update dependency com.google.errorprone:error_prone_annotations to v2.5.1 ([#299](https://www.github.com/googleapis/java-dns/issues/299)) ([4919dcc](https://www.github.com/googleapis/java-dns/commit/4919dcc394a85b75d504b50167417d76c4a0a80a))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees
No one assigned
Labels
api: dns Issues related to the googleapis/java-dns API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose DNSSEC options when creating ManagedZones
2 participants
@athakor @chingor13