-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base transaction retries on error codes #129
feat: base transaction retries on error codes #129
Conversation
Update Fork
79a8dd2
to
0aafdb5
Compare
b40a2e8
to
fcd4ea1
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
============================================
+ Coverage 71.62% 72.58% +0.96%
- Complexity 969 988 +19
============================================
Files 62 63 +1
Lines 5222 5270 +48
Branches 579 590 +11
============================================
+ Hits 3740 3825 +85
+ Misses 1302 1259 -43
- Partials 180 186 +6
Continue to review full report at Codecov.
|
@BenWhitehead Can you ask someone to review or review this yourself if you have time? This one is a little trickier :/ |
@schmidt-sebastian Sure, I'll dig into this tomorrow first thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks okay. A few questions and one request to move a method.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/LocalFirestoreHelper.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the review! All feedback addressed.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/TransactionRunner.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/LocalFirestoreHelper.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I'm looking into the Linkage Checker status check failure and will let you know if it requires anything to be change in the PR.
Port of googleapis/nodejs-firestore#953
Implements go/transaction-retry-matrix for Java and cleans up some of the tests: