Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The location of the SPI metadata is wrong which prevents correct registration of the ServletContainerInitializer #70

Closed
minherz opened this issue Feb 8, 2022 · 0 comments · Fixed by #72
Closed

The location of the SPI metadata is wrong which prevents correct registration of the ServletContainerInitializer #70

minherz opened this issue Feb 8, 2022 · 0 comments · Fixed by #72
Assignees
@minherz
Labels
api: logging Issues related to the googleapis/java-logging-servlet-initializer API. lang: java Issues specific to Java. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@minherz
Copy link
Collaborator

minherz commented Feb 8, 2022

Current location of the META-INF/services/javax.servlet.ServletContainerInitializer is incorrect. The file should be placed under src/main instead of src/main/java. In its current location it is not recognized by the SPI mechanism and the initializer is not registered.
@minherz minherz added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. lang: java Issues specific to Java. labels Feb 8, 2022
@minherz minherz self-assigned this Feb 8, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging-servlet-initializer API. label Feb 8, 2022
@minherz minherz mentioned this issue Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
api: logging Issues related to the googleapis/java-logging-servlet-initializer API. lang: java Issues specific to Java. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: move META-INF folder to the correct location googleapis/java-logging-servlet-initializer
1 participant
@minherz