feat: expose default client configs #541

hannahrogers-google · 2021-02-25T21:09:15Z

Fixes #373 ☕️

fix issue #6784

Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.

lettering is not enabled

… attempt

ack operations

connection

publisher

…to master

This reverts commit fef9956.

codecov · 2021-02-25T21:19:15Z

Codecov Report

Merging #541 (a0c2511) into master (491b954) will increase coverage by 0.07%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #541      +/-   ##
============================================
+ Coverage     78.79%   78.86%   +0.07%     
- Complexity      376      377       +1     
============================================
  Files            27       27              
  Lines          3414     3416       +2     
  Branches        171      171              
============================================
+ Hits           2690     2694       +4     
+ Misses          651      650       -1     
+ Partials         73       72       -1

Impacted Files	Coverage Δ	Complexity Δ
...in/java/com/google/cloud/pubsub/v1/Subscriber.java	`80.61% <83.33%> (+0.09%)`	`23.00 <0.00> (+1.00)`
...ain/java/com/google/cloud/pubsub/v1/Publisher.java	`87.65% <100.00%> (+0.51%)`	`47.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491b954...fe058f0. Read the comment docs.

hannahrogers-google added 30 commits November 25, 2019 10:04

Modifying Publish example in README to match other examples given, and

19dd129

fix issue #6784

fix: Modifying Publish example in README to match other examples, and

4158529

fix Issue googleapis#11

Merge branch 'master' of github.com:hannahrogers-google/java-pubsub

7d704f0

Merge branch 'master' of https://github.com/googleapis/java-pubsub

9e0ebc6

feat: Adding support for DLQs

01d41b7

Adding delivery attempt count to PubsubMessages as a message attribute, and creating helper function to allow users to get the count without knowing implementation details.

Fix formatting

ed3b1ee

fix: making changes requested in pull request

72f7996

Merge branch 'master' of https://github.com/googleapis/java-pubsub

389cb86

Merge branch 'master' of https://github.com/googleapis/java-pubsub

c9e4bd2

fix: creating fix to not populate delivery attempt attribute when dead

3738ec8

lettering is not enabled

Merge branch 'master' of https://github.com/googleapis/java-pubsub

4ce1d3b

Adding unit test for case in which a received message has no delivery…

aecd4ca

… attempt

Making MessageWaiter class more generic to also be used for outstanding

77fa3b3

ack operations

Merge branch 'master' of https://github.com/googleapis/java-pubsub

b87023c

Merge branch 'master' into fix-subscriber-stop

7086b3c

Waiting for acks to complete before shutting down a streaming subscriber

da0e355

connection

Fixing formatting error

dc55fc1

Merge branch 'master' of https://github.com/googleapis/java-pubsub

45beee2

fix: making sure all publishes complete before shutting down the

548b7a7

publisher

Merge branch 'master' of https://github.com/googleapis/java-pubsub

76a1de9

Merge branch 'master' of https://github.com/googleapis/java-pubsub

a8989f1

adding default max outstanding request bytes

b4439fd

Merge branch 'master' of https://github.com/googleapis/java-pubsub

01f607c

Merge branch 'master' of https://github.com/googleapis/java-pubsub

c0cddb3

fix: make push endpoint valid https

9a6381d

Merge branch 'master' of https://github.com/googleapis/java-pubsub

0bd165f

Merge branch 'master' of https://github.com/googleapis/java-pubsub

5d47be8

Merge branch 'master' of https://github.com/googleapis/java-pubsub in…

e3b7f6d

…to master

Merge branch 'master' of https://github.com/googleapis/java-pubsub in…

6c1a26c

…to master

fix: use default zero value if a flow control setting is not provided

f2fa6b8

hannahrogers-google added 18 commits August 6, 2020 19:57

fix: better cleanup during publisher test

78d98e8

fix: format issues

785c3ee

Merge branch 'master' of https://github.com/googleapis/java-pubsub

dbe753f

fix: test timeouts should be a minute

35c2c6e

Merge branch 'master' of https://github.com/googleapis/java-pubsub

8fd6691

fix: make subscriberIt less flaky

b76e387

Merge branch 'master' of https://github.com/googleapis/java-pubsub

c855f24

fix: add deprecated tag for deprecated methods

d274df4

Merge branch 'master' of https://github.com/googleapis/java-pubsub

5663e12

fix: retrying sync pulls in subscriberIT test

fef9956

Revert "fix: retrying sync pulls in subscriberIT test"

87ebc6b

This reverts commit fef9956.

Merge branch 'master' of https://github.com/googleapis/java-pubsub

9ac49ea

Merge branch 'master' of https://github.com/googleapis/java-pubsub

d7040f3

fix: do not send ModAck if auto ack extensions are disabled

70c21a1

Merge branch 'master' of https://github.com/googleapis/java-pubsub

fa5b7ff

Adding test for zero ack extension

fc13a98

Merge branch 'master' of https://github.com/googleapis/java-pubsub

39bbc85

feat: expose default client configs

648c0ec

hannahrogers-google requested a review from a team as a code owner February 25, 2021 21:09

product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Feb 25, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2021

fix: revert unexpected changes

fe058f0

hannahrogers-google requested review from hongalex and kamalaboulhosn February 25, 2021 21:14

anguillanneuf approved these changes Mar 2, 2021

View reviewed changes

hongalex approved these changes Mar 9, 2021

View reviewed changes

hannahrogers-google merged commit 01e6daf into googleapis:master Mar 11, 2021

This was referenced Mar 16, 2021

Bump google-cloud-pubsub from 1.61.0 to 1.112.0 ConnectionMaster/gcp-ingestion#41

Closed

Bump google-cloud-pubsub from 1.61.0 to 1.112.0 fbertsch/gcp-ingestion#34

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: expose default client configs #541

feat: expose default client configs #541

hannahrogers-google commented Feb 25, 2021

codecov bot commented Feb 25, 2021 •

edited

Loading

feat: expose default client configs #541

feat: expose default client configs #541

Conversation

hannahrogers-google commented Feb 25, 2021

codecov bot commented Feb 25, 2021 • edited Loading

Codecov Report

codecov bot commented Feb 25, 2021 •

edited

Loading