Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create a separate CachedSubscriberClients class instead of caching clients in the serializable data source options #519

Merged
merged 8 commits into from
Nov 29, 2022

Conversation

hannahrogers-google
Copy link
Contributor

No description provided.

hannahrogers-google and others added 8 commits November 16, 2022 21:54
* fix: respect max messages per batch option

* fix formatting

* fix: use single subscriber service client

* fix public method

* fix: resolve todo

* remove unused dep
…bscribers created (googleapis#513)

* fix: respect max messages per batch option

* fix formatting

* fix: use single subscriber service client

* fix public method

* fix: mark the service client transient

* fix: guard by this
@hannahrogers-google hannahrogers-google requested a review from a team as a code owner November 23, 2022 14:49
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. labels Nov 23, 2022
@hannahrogers-google hannahrogers-google added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@hannahrogers-google hannahrogers-google merged commit d2a2ea8 into googleapis:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants