Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

feat: expose apis of resourcemanager folders #99

Merged
merged 14 commits into from
Apr 13, 2020
Merged

feat: expose apis of resourcemanager folders #99

merged 14 commits into from
Apr 13, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Mar 13, 2020

Fixes #92

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 13, 2020
@codecov
Copy link

codecov bot commented Mar 13, 2020 •
edited
Loading

Codecov Report

Merging #99 into master will decrease coverage by 3.65%.
The diff coverage is 73.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
- Coverage     85.82%   82.16%   -3.66%     
- Complexity      210      248      +38     
============================================
  Files            11       13       +2     
  Lines           945     1329     +384     
  Branches        100      138      +38     
============================================
+ Hits            811     1092     +281     
- Misses          101      167      +66     
- Partials         33       70      +37
Impacted Files Coverage Δ Complexity Δ
.../google/cloud/resourcemanager/ResourceManager.java 81.48% <0.00%> (-14.18%) 0.00 <0.00> (ø)
...rcemanager/spi/v1beta1/HttpResourceManagerRpc.java 58.33% <0.00%> (-18.91%) 13.00 <0.00> (ø)
...m/google/cloud/resourcemanager/ConstraintInfo.java 82.85% <82.85%> (ø) 15.00 <15.00> (?)
...om/google/cloud/resourcemanager/OrgPolicyInfo.java 82.85% <82.85%> (ø) 15.00 <15.00> (?)
...gle/cloud/resourcemanager/ResourceManagerImpl.java 87.56% <87.65%> (+0.06%) 24.00 <8.00> (+8.00)
...esourcemanager/spi/v1beta1/ResourceManagerRpc.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0efcce2...c2bbaac. Read the comment docs.

@athakor athakor requested review from chingor13 and a team March 13, 2020 04:27
elharo
elharo suggested changes Mar 13, 2020
View reviewed changes
clirr-ignored-differences.xml Outdated Show resolved Hide resolved
@athakor athakor added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Mar 20, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 20, 2020
elharo
elharo reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The combination of

  1. Very large PR size
  2. Fully package qualified names
  3. Long classes with public inner classes

makes this PR very hard to understand. I'm not confident I am following this in the large.

src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/OrgPolicy.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ConstraintTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/OrgPolicyInfoTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/OrgPolicyInfoTest.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2020
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 31, 2020
@athakor athakor force-pushed the resourcemanager-92 branch from 7291554 to 3232c93 Compare April 1, 2020 14:19
@athakor
Copy link
Contributor Author

athakor commented Apr 1, 2020

@elharo PTAL

@athakor
Copy link
Contributor Author

athakor commented Apr 1, 2020

@elharo all the comment have been addressed. PTAL

@athakor
Copy link
Contributor Author

athakor commented Apr 2, 2020

@elharo PTAL

@athakor
Copy link
Contributor Author

athakor commented Apr 2, 2020

@elharo gentle ping

elharo
elharo reviewed Apr 2, 2020
View reviewed changes
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/OrgPolicyInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/spi/v1beta1/ResourceManagerRpc.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/spi/v1beta1/ResourceManagerRpc.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/spi/v1beta1/ResourceManagerRpc.java Outdated Show resolved Hide resolved
@athakor
Copy link
Contributor Author

athakor commented Apr 3, 2020

@elharo PTAL

elharo
elharo reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many tests here are incorrectly using mocks and making other mistakes. Writing the tests first and making sure they fail before writing the model code to make them pass would avoid this.

src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
src/test/java/com/google/cloud/resourcemanager/ResourceManagerImplTest.java Outdated Show resolved Hide resolved
elharo
elharo suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

@athakor
Copy link
Contributor Author

athakor commented Apr 6, 2020

Please fix tests

@elharo all the tests have been fixed. PTAL

@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 6, 2020
elharo
elharo reviewed Apr 6, 2020
View reviewed changes
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/ConstraintInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/OrgPolicyInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/OrgPolicyInfo.java Outdated Show resolved Hide resolved
src/main/java/com/google/cloud/resourcemanager/OrgPolicyInfo.java Outdated Show resolved Hide resolved
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@athakor athakor force-pushed the resourcemanager-92 branch from 11f9992 to 9d4e4a5 Compare April 13, 2020 06:11
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2020
@athakor
Copy link
Contributor Author

athakor commented Apr 13, 2020

@elharo PTAL

@athakor
Copy link
Contributor Author

athakor commented Apr 13, 2020

@elharo PTAL

@athakor
Copy link
Contributor Author

athakor commented Apr 13, 2020

@elharo gentle ping

@athakor athakor merged commit d998fab into googleapis:master Apr 13, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 11, 2020
@release-please
chore: release 0.118.0 (#135)
036b018 
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.118.0](https://www.github.com/googleapis/java-resourcemanager/compare/v0.117.2...v0.118.0) (2020-08-10)


### Features

* expose apis of resourcemanager folders ([#99](https://www.github.com/googleapis/java-resourcemanager/issues/99)) ([d998fab](https://www.github.com/googleapis/java-resourcemanager/commit/d998fabea7126fe8653369258c82eac1f4b20b88))
* implement testPermission api of organizations ([#125](https://www.github.com/googleapis/java-resourcemanager/issues/125)) ([317a172](https://www.github.com/googleapis/java-resourcemanager/commit/317a172b77bb76e053d2a5b9050c21d3c9526158))
* **deps:** adopt flatten plugin and google-cloud-shared-dependencies ([#191](https://www.github.com/googleapis/java-resourcemanager/issues/191)) ([0c97eb5](https://www.github.com/googleapis/java-resourcemanager/commit/0c97eb584fcc37c66c3af01a67158d5a1155eb31))


### Dependencies

* update core dependencies ([#133](https://www.github.com/googleapis/java-resourcemanager/issues/133)) ([5b4393a](https://www.github.com/googleapis/java-resourcemanager/commit/5b4393a570b8578d4611c0dc14a07c97567b548a))
* update core dependencies to v1.93.3 ([#104](https://www.github.com/googleapis/java-resourcemanager/issues/104)) ([273e621](https://www.github.com/googleapis/java-resourcemanager/commit/273e621ec47c63ec1245a4ba6862d564dd5db013))
* update dependency com.google.api:api-common to v1.9.0 ([#120](https://www.github.com/googleapis/java-resourcemanager/issues/120)) ([7112223](https://www.github.com/googleapis/java-resourcemanager/commit/7112223387a6c5faef7626a6acfcbf4b6306377f))
* update dependency com.google.api:api-common to v1.9.1 ([#168](https://www.github.com/googleapis/java-resourcemanager/issues/168)) ([9637680](https://www.github.com/googleapis/java-resourcemanager/commit/96376804729f407a8c329a117a5df5b119636ac5))
* update dependency com.google.api:api-common to v1.9.2 ([#174](https://www.github.com/googleapis/java-resourcemanager/issues/174)) ([efc0b2d](https://www.github.com/googleapis/java-resourcemanager/commit/efc0b2dc8bbc9f0cb67eab0f386338f1eb013947))
* update dependency com.google.api:gax-bom to v1.55.0 ([#124](https://www.github.com/googleapis/java-resourcemanager/issues/124)) ([dc2002f](https://www.github.com/googleapis/java-resourcemanager/commit/dc2002fe22146d67a2d31b38e163d6c029c161fc))
* update dependency com.google.apis:google-api-services-cloudresourcemanager to v1-rev20200311-1.30.9 ([#100](https://www.github.com/googleapis/java-resourcemanager/issues/100)) ([9af1f5d](https://www.github.com/googleapis/java-resourcemanager/commit/9af1f5d1fc1d17976b3e0a5ea9f5ebc4803993ee))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.2 ([#204](https://www.github.com/googleapis/java-resourcemanager/issues/204)) ([c5fac70](https://www.github.com/googleapis/java-resourcemanager/commit/c5fac70539cba1593d31b845ee4e833dac3a4b19))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.4 ([#206](https://www.github.com/googleapis/java-resourcemanager/issues/206)) ([c16b9cf](https://www.github.com/googleapis/java-resourcemanager/commit/c16b9cf92f223a1de4a7e436c6b196d7610b25f4))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.8.6 ([#212](https://www.github.com/googleapis/java-resourcemanager/issues/212)) ([36522d3](https://www.github.com/googleapis/java-resourcemanager/commit/36522d355f4191c966b3b43f2b9a2be2c15e80d7))
* update dependency com.google.guava:guava-bom to v29 ([#138](https://www.github.com/googleapis/java-resourcemanager/issues/138)) ([0a5b057](https://www.github.com/googleapis/java-resourcemanager/commit/0a5b05730f69b6e6307488b2e31ce8a148b68110))
* update dependency com.google.http-client:google-http-client-bom to v1.35.0 ([#156](https://www.github.com/googleapis/java-resourcemanager/issues/156)) ([9a87e02](https://www.github.com/googleapis/java-resourcemanager/commit/9a87e026c77de190a0d5d3824fb5ff8adf024680))
* update dependency com.google.protobuf:protobuf-bom to v3.12.0 ([#162](https://www.github.com/googleapis/java-resourcemanager/issues/162)) ([2f40eaf](https://www.github.com/googleapis/java-resourcemanager/commit/2f40eafff39136104d1483bda82706ba599af7ca))
* update dependency com.google.protobuf:protobuf-bom to v3.12.2 ([#166](https://www.github.com/googleapis/java-resourcemanager/issues/166)) ([1d8a5b9](https://www.github.com/googleapis/java-resourcemanager/commit/1d8a5b910520b351870e80b00ab85f2aa25a382a))
* update dependency org.threeten:threetenbp to v1.4.2 ([#112](https://www.github.com/googleapis/java-resourcemanager/issues/112)) ([da637f0](https://www.github.com/googleapis/java-resourcemanager/commit/da637f0a32a3bdc63faaffb564e06121e186b24c))
* update dependency org.threeten:threetenbp to v1.4.3 ([#131](https://www.github.com/googleapis/java-resourcemanager/issues/131)) ([ee08cde](https://www.github.com/googleapis/java-resourcemanager/commit/ee08cdea780a57b2b76295bc4081c35e03ffd0f2))
* update dependency org.threeten:threetenbp to v1.4.4 ([#155](https://www.github.com/googleapis/java-resourcemanager/issues/155)) ([1ba27f4](https://www.github.com/googleapis/java-resourcemanager/commit/1ba27f49ea1509f63dda378e9af326502d1606a2))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elharo elharo elharo approved these changes

@chingor13 chingor13 Awaiting requested review from chingor13

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Apis of Resourcemanager folders.
5 participants
@athakor @elharo @googlebot @pmakani @yoshi-kokoro