Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add native image feature to register protobuf reflection in tests #347

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Nov 3, 2021

Fixes native image test failures such as in googleapis/java-accesscontextmanager#270 where tests use reflection on protobuf classes.

@dzou dzou requested a review from a team November 3, 2021 21:59
@dzou dzou requested a review from a team as a code owner November 3, 2021 21:59
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2021
Copy link

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this repo hasn't yet applied the fix to enable the Java 17 test? Ignoring the Java 17 failure, LGTM.

@dzou
Copy link
Contributor Author

dzou commented Nov 5, 2021

I guess this repo hasn't yet applied the fix to enable the Java 17 test? Ignoring the Java 17 failure, LGTM.

Ah, I see. Thank you for clarifying this. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants