perf: use PLAN mode to get result metadata #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting the result metadata of a PreparedStatement should not execute the query, but should instead just request the query plan. This will also return the metadata of the query.
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
============================================
+ Coverage 71.96% 71.98% +0.02%
- Complexity 1132 1135 +3
============================================
Files 24 24
Lines 3524 3534 +10
Branches 539 541 +2
============================================
+ Hits 2536 2544 +8
- Misses 769 771 +2
Partials 219 219
Continue to review full report at Codecov.
|
thiagotnunes
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
PreparedStatement#getMetaData()actually executed the query or DML statement of thePreparedStatement. This PR changes that to only executing the statement inPLANmode to get the metadata of the statement. That is:PLANmode is allowed with unbound parameters.This change also allows calling
PreparedStatement#getMetaData()for DML statements. This will result in an emptyResultSetMetaDatainstance, as DML statements do not return any relevant information for aResultSetMetaData.Fixes #387