-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add samples for backup schedule feature APIs. #3339
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Pull request size is large.
api: spanner
Issues related to the googleapis/java-spanner API.
samples
Issues that are directly related to samples.
labels
Sep 18, 2024
rahul2393
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 19, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 19, 2024
ketanv3
reviewed
Sep 20, 2024
samples/snippets/src/main/java/com/example/spanner/CreateBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
ketanv3
reviewed
Sep 20, 2024
samples/snippets/src/main/java/com/example/spanner/CreateBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/CreateBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/CreateIncrementalBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/CreateIncrementalBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/DeleteBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/GetBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListBackupSchedulesSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListBackupSchedulesSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/UpdateBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/UpdateBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
rahul2393
approved these changes
Sep 23, 2024
ketanv3
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few minor changes needed.
samples/snippets/src/main/java/com/example/spanner/ListBackupSchedulesSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/CreateFullBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/CreateIncrementalBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/GetBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/ListBackupSchedulesSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/UpdateBackupScheduleSample.java
Outdated
Show resolved
Hide resolved
Thanks for the changes, @aman-19. LGTM! |
rahul2393
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
api: spanner
Issues related to the googleapis/java-spanner API.
labels
Sep 24, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Sep 24, 2024
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/java-spanner API.
label
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/java-spanner API.
samples
Issues that are directly related to samples.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code samples for the following APIs:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #3338 ☕️