Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement writeWithResponse in FakeStorageRpc #175

Closed
rbraeunlich opened this issue Jul 20, 2020 · 1 comment · Fixed by #187
Closed

Implement writeWithResponse in FakeStorageRpc #175

rbraeunlich opened this issue Jul 20, 2020 · 1 comment · Fixed by #187
Assignees
@athakor
Labels
api: storage Issues related to the googleapis/java-storage-nio API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@rbraeunlich
Copy link

Is your feature request related to a problem? Please describe.
With Pull Request #135 the FakeStorageRpc class extends StorageRpcTestBase and now google-cloud-storage is a needed dependency when using the class in tests. In google-cloud-storage the implementation of BlobWriteChannel has been changed a month ago (https://github.com/googleapis/java-storage/pull/269/files#diff-8561e6a9172119adf8e882a3f5298d6bR69) so that flushBuffer now calls writeWithResponse instead of write.
writeWithResponse is neither implemented in FakeStorageRpc nor in StorageRpcTestBase, which causes my tests to crash now, which didn't happen before.

Describe the solution you'd like
Please implement the method. Since the response is a StorageObject it shouldn't cause any problems.

Describe alternatives you've considered
My workaround is now to set my dependency to google-cloud-storage fixed to 1.110.0. But this pins me on this version.
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Jul 20, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 20, 2020
@MartinHaeusler
Copy link

The same thing happened to me as well. Can't upgrade my cloud storage client until this issue is resolved...

@athakor athakor added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Jul 27, 2020
@athakor athakor self-assigned this Jul 27, 2020
@athakor athakor mentioned this issue Aug 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athakor athakor

Labels
api: storage Issues related to the googleapis/java-storage-nio API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: implement writeWithResponse in FakeStorageRpc athakor/java-storage-nio
4 participants
@rbraeunlich @MartinHaeusler @yoshi-automation @athakor