Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rely on google core for SSLException's #188

Merged
merged 4 commits into from
Mar 17, 2020
Merged

fix: rely on google core for SSLException's #188

merged 4 commits into from
Mar 17, 2020

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Mar 16, 2020

Fixes: #187

@frankyn frankyn requested a review from JesseLovelace March 16, 2020 19:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #188 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     63.62%   63.63%   +0.01%     
  Complexity      546      546              
============================================
  Files            30       30              
  Lines          4778     4777       -1     
  Branches        429      428       -1     
============================================
  Hits           3040     3040              
  Misses         1577     1577              
+ Partials        161      160       -1
Impacted Files Coverage Δ Complexity Δ
...ava/com/google/cloud/storage/StorageException.java 100% <ø> (+7.69%) 9 <0> (ø) ⬇️
...gle/cloud/storage/testing/RemoteStorageHelper.java 63.93% <0%> (-0.53%) 9 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3795825...b2eabf5. Read the comment docs.

@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@frankyn frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@frankyn frankyn merged commit 2581f3c into master Mar 17, 2020
@frankyn frankyn deleted the update-core branch March 17, 2020 01:15
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update java-core dep to include retrying SSLException when released 1.93.3
4 participants