Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose updateTime field of the bucket #449

Merged
merged 6 commits into from
Aug 5, 2020
Merged

feat: expose updateTime field of the bucket #449

merged 6 commits into from
Aug 5, 2020

Conversation

athakor
Copy link
Contributor

@athakor athakor commented Aug 4, 2020

Fixes #448

@athakor athakor requested a review from frankyn August 4, 2020 12:53
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 4, 2020
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 5, 2020 •
edited
Loading

Codecov Report

Merging #449 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
+ Coverage     63.12%   63.19%   +0.07%     
- Complexity      610      622      +12     
============================================
  Files            32       32              
  Lines          5133     5144      +11     
  Branches        490      491       +1     
============================================
+ Hits           3240     3251      +11     
  Misses         1729     1729              
  Partials        164      164
Impacted Files Coverage Δ Complexity Δ
...src/main/java/com/google/cloud/storage/Bucket.java 82.20% <100.00%> (+0.12%) 34.00 <0.00> (ø)
...main/java/com/google/cloud/storage/BucketInfo.java 82.01% <100.00%> (+0.27%) 86.00 <1.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce82cc...6c2f688. Read the comment docs.

dmitry-fa
dmitry-fa approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@dmitry-fa dmitry-fa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frankyn frankyn merged commit f0e945e into googleapis:master Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-fa dmitry-fa dmitry-fa approved these changes

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose updateTime field of the bucket's
4 participants
@athakor @frankyn @dmitry-fa @yoshi-kokoro