feat: add support of public access prevention #636

athakor · 2020-11-26T12:11:04Z

Fixes #616

codecov · 2020-11-26T12:17:43Z

Codecov Report

Merging #636 (37e19e3) into master (1dfcc02) will increase coverage by 0.11%.
The diff coverage is 88.00%.

❗ Current head 37e19e3 differs from pull request most recent head ec75bb2. Consider uploading reports for the commit ec75bb2 to get more accurate results

@@             Coverage Diff              @@
##             master     #636      +/-   ##
============================================
+ Coverage     64.62%   64.73%   +0.11%     
  Complexity      634      634              
============================================
  Files            32       32              
  Lines          5314     5337      +23     
  Branches        519      522       +3     
============================================
+ Hits           3434     3455      +21     
- Misses         1718     1719       +1     
- Partials        162      163       +1

Impacted Files	Coverage Δ
...main/java/com/google/cloud/storage/BucketInfo.java	`84.24% <88.00%> (+0.24%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad4a31...ec75bb2. Read the comment docs.

athakor · 2020-11-26T12:25:22Z

@shaffeeullah @tritone

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java

google-cloud-storage/src/test/java/com/google/cloud/storage/BucketInfoTest.java

elharo · 2020-12-04T17:14:58Z

Dec 03, 2020 7:29:41 AM com.google.cloud.tools.dependencies.linkagemonitor.LinkageMonitor run
SEVERE: Newly introduced problems:
(com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10) com.google.api.services.storage.model.Bucket$IamConfiguration's method setPublicAccessPrevention(String) is not found
  referenced from com.google.cloud.storage.BucketInfo (com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT)
(com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10) com.google.api.services.storage.model.Bucket$IamConfiguration's method getPublicAccessPrevention() is not found
  referenced from com.google.cloud.storage.BucketInfo (com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT)

com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10 is at:
  com.google.cloud:google-cloud-nio:0.122.1 (compile) / com.google.apis:google-api-services-storage:v1-rev20200927-1.30.10 (compile)
  and 2 other dependency paths.
com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT is at:
  com.google.cloud:google-cloud-storage:1.113.5-SNAPSHOT (compile)

frankyn · 2020-12-04T18:36:33Z

For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well.

tritone · 2020-12-11T00:46:15Z

For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well.

Looks like this has been completed. @athakor can you merge in master?

athakor · 2020-12-11T05:27:33Z

For the linker issues, we need to cut a new release of storage with the updated Apiary client (#613) and a new release of libraries-bom as well.

Looks like this has been completed. @athakor can you merge in master?

done.. Still linker issue

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java

I'm now running point as co-author

frankyn

@BenWhitehead can you take a look when you have a moment?

BenWhitehead

A couple new nits, and the outstanding valueOf call

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>

tritone

Thanks so much for fixing this up Ben!

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java

tritone

Looks like there is a lint failure; otherwise LGTM

…zed value when set to UNKNOWN

shaffeeullah · 2021-06-08T20:45:41Z

@BenWhitehead & @frankyn ,

We would like to merge and release this feature next Monday (06/14/21). Does that work for you? Do one of you have bandwidth this week to resolve the conflicts? Sorry, I know this PR has been open for a while.

snippet-bot · 2021-06-10T22:28:03Z

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

shaffeeullah · 2021-06-11T19:58:51Z

Public access prevention rollout has been delayed due to a bug surfaced during Googler preview. I will keep this PR updated as I learn new release timeline details.

shaffeeullah · 2021-06-28T17:47:26Z

@BenWhitehead This feature can now be merged and released.

feat: add support of public access prevention

57425e3

product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Nov 26, 2020

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2020

athakor requested review from frankyn and JesseLovelace November 26, 2020 12:11

athakor added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 27, 2020

yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 27, 2020

frankyn requested changes Nov 30, 2020

View reviewed changes

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated Show resolved Hide resolved

google-cloud-storage/src/test/java/com/google/cloud/storage/BucketInfoTest.java Outdated Show resolved Hide resolved

athakor added 2 commits December 3, 2020 12:05

feat: add integration test and fix review changes

29b8e13

fix: build

6292407

tritone marked this pull request as ready for review December 11, 2020 00:45

tritone requested a review from a team December 11, 2020 00:45

Merge remote-tracking branch 'upstream/master' into storage-616

0aedfef

athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 11, 2020

frankyn self-requested a review December 11, 2020 16:54

frankyn previously requested changes Dec 14, 2020

View reviewed changes

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated Show resolved Hide resolved

frankyn mentioned this pull request Dec 14, 2020

feat(storage): public access prevention googleapis/google-cloud-java#7423

Merged

feat: address review changes

6c06659

athakor requested review from frankyn and tritone December 21, 2020 13:35

athakor requested a review from a team December 31, 2020 08:27

address issue in test set up

c8df138

frankyn removed their request for review March 10, 2021 00:48

frankyn reviewed Mar 10, 2021

View reviewed changes

BenWhitehead requested changes Mar 11, 2021

View reviewed changes

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated Show resolved Hide resolved

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Outdated Show resolved Hide resolved

frankyn and others added 2 commits March 11, 2021 22:07

Apply suggestions from code review

125da9f

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>

fail valueOf gracefully

2da9fa4

frankyn requested a review from BenWhitehead March 22, 2021 16:44

BenWhitehead approved these changes Mar 22, 2021

View reviewed changes

fix: add UNKNOWN enum value to PublicAccessPrevention

a042d43

BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 6, 2021

tritone reviewed May 7, 2021

View reviewed changes

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Show resolved Hide resolved

google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java Show resolved Hide resolved

fix: add comment to unknown

21b7659

tritone approved these changes May 7, 2021

View reviewed changes

fix: add test to ensure publicAccessPrevention is absent from seriali…

37e19e3

…zed value when set to UNKNOWN

Merge branch 'master' into storage-616

ec75bb2

frankyn added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 10, 2021

frankyn added the status: blocked Resolving the issue is dependent on other work. label Jun 11, 2021

BenWhitehead added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 14, 2021

BenWhitehead removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Jun 28, 2021

BenWhitehead merged commit 3d1e482 into googleapis:master Jun 28, 2021

release-please bot mentioned this pull request Aug 10, 2022

chore(main): release 2.11.4 #1564

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support of public access prevention #636

feat: add support of public access prevention #636

athakor commented Nov 26, 2020 •

edited

Loading

codecov bot commented Nov 26, 2020 •

edited

Loading

athakor commented Nov 26, 2020

elharo commented Dec 4, 2020

frankyn commented Dec 4, 2020 •

edited

Loading

tritone commented Dec 11, 2020

athakor commented Dec 11, 2020 •

edited

Loading

frankyn left a comment

BenWhitehead left a comment

tritone left a comment

tritone left a comment

shaffeeullah commented Jun 8, 2021 •

edited

Loading

snippet-bot bot commented Jun 10, 2021

shaffeeullah commented Jun 11, 2021

shaffeeullah commented Jun 28, 2021

feat: add support of public access prevention #636

feat: add support of public access prevention #636

Conversation

athakor commented Nov 26, 2020 • edited Loading

codecov bot commented Nov 26, 2020 • edited Loading

Codecov Report

athakor commented Nov 26, 2020

elharo commented Dec 4, 2020

frankyn commented Dec 4, 2020 • edited Loading

tritone commented Dec 11, 2020

athakor commented Dec 11, 2020 • edited Loading

frankyn left a comment

Choose a reason for hiding this comment

BenWhitehead left a comment

Choose a reason for hiding this comment

tritone left a comment

Choose a reason for hiding this comment

tritone left a comment

Choose a reason for hiding this comment

shaffeeullah commented Jun 8, 2021 • edited Loading

snippet-bot bot commented Jun 10, 2021

No region tags are edited in this PR.

shaffeeullah commented Jun 11, 2021

shaffeeullah commented Jun 28, 2021

athakor commented Nov 26, 2020 •

edited

Loading

codecov bot commented Nov 26, 2020 •

edited

Loading

frankyn commented Dec 4, 2020 •

edited

Loading

athakor commented Dec 11, 2020 •

edited

Loading

shaffeeullah commented Jun 8, 2021 •

edited

Loading