Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build!: update gts and typescript #283

Merged
merged 1 commit into from
Mar 24, 2020
Merged

build!: update gts and typescript #283

merged 1 commit into from
Mar 24, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 24, 2020

BREAKING CHANGE: typescript@3.7.x introduced breaking changes to compiled code

BREAKING CHANGE: typescript@3.7.x introduced breaking changes to compiled code
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2020
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #283 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   97.79%   97.47%   -0.32%     
==========================================
  Files           1        1              
  Lines         317      317              
  Branches       58       52       -6     
==========================================
- Hits          310      309       -1     
- Misses          7        8       +1     
Impacted Files Coverage Δ
src/index.ts 97.47% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de146f...2c4d2bd. Read the comment docs.

Copy link
Contributor

@summer-ji-eng summer-ji-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestion

@bcoe bcoe merged commit ff076dc into master Mar 24, 2020
@bcoe bcoe deleted the gts-typescript branch March 24, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants