Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from /v4 token endpoint to https://oauth2.googleapis.com/token #388

Open
bcoe opened this issue Jul 22, 2021 · 0 comments · May be fixed by #466
Open

Move away from /v4 token endpoint to https://oauth2.googleapis.com/token #388

bcoe opened this issue Jul 22, 2021 · 0 comments · May be fixed by #466
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@bcoe
Copy link
Contributor

bcoe commented Jul 22, 2021

Nit: we're trying to centralize the different token exchange endpoints to 'https://oauth2.googleapis.com/token', even though this is a mock, it might be good for new code to just show that one, unless you think it would be confusing to have different endpoints in the code if elsewhere you're using the one you have here.

CC: @silvolu
Refs: https://github.com/googleapis/google-auth-library-nodejs/pull/1207/files#r674094849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update token endpoints to non-deprecated endpoints ddelgrosso1/node-gtoken
1 participant
@bcoe