Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Enhanced library: refactor or remove value-converter.ts #28

Closed
telpirion opened this issue Dec 17, 2020 · 2 comments
Closed

Enhanced library: refactor or remove value-converter.ts #28

telpirion opened this issue Dec 17, 2020 · 2 comments
Labels
api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. type: cleanup An internal cleanup or hygiene concern.

Comments

@telpirion
Copy link
Contributor

Waiting on this PR in protobuf.js.

The src/value-converter.ts allows conversion between Message and Value objects. When the above-mentioned PR is submitted, we will use protobuf.js instead for this conversion. At that time, the value-converter.ts file will be deleted and all the conversion logic will be contained in src/helpers.ts.

@sofisl sofisl added the type: process A process-related concern. May include testing, release, or the like. label Dec 18, 2020
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 13, 2021
@alexander-fenster
Copy link
Contributor

alexander-fenster commented Oct 8, 2021

Since we first discussed this problem, I published an npm package for exactly this purpose. Can we start using it here?

@kweinmeister kweinmeister added type: cleanup An internal cleanup or hygiene concern. and removed type: process A process-related concern. May include testing, release, or the like. labels Jan 13, 2022
@product-auto-label product-auto-label bot added api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. and removed api: aiplatform Issues related to the AI Platform API. labels May 5, 2022
@rosiezou
Copy link

Closing this issue because it is no longer applicable, given that JSON serialization/deserialization is now implemented in a separate package: https://www.npmjs.com/package/proto3-json-serializer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

6 participants