Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat(samples): add samples for analyzeIamPolicy and analyzeIamPolicyLongrunning #433

Merged
merged 13 commits into from
Jan 28, 2021

Conversation

donghez-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@donghez-google donghez-google requested a review from a team as a code owner November 21, 2020 01:20
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 21, 2020
@product-auto-label product-auto-label bot added api: cloudasset Issues related to the googleapis/nodejs-asset API. samples Issues that are directly related to samples. labels Nov 21, 2020
@snippet-bot
Copy link

snippet-bot bot commented Nov 21, 2020

Here is the summary of changes.

You added 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link

codecov bot commented Nov 21, 2020

Codecov Report

Merging #433 (0eb3ce2) into master (a634159) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files          13       13           
  Lines        5331     5331           
  Branches      225      225           
=======================================
  Hits         5166     5166           
  Misses        160      160           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a634159...0eb3ce2. Read the comment docs.

@donghez-google
Copy link
Contributor Author

Question about linting:
I tried "npm run fix" and "npm run lint -- --fix", both of them returned error "missing script: fix". Where can I get the fix script?

@bcoe
Copy link
Contributor

bcoe commented Nov 23, 2020

@donghez-google it sounds like you're potentially running npm run fix in the wrong folder, I'm guessing you're in ./samples, and you want to run int he top level folder.

If you run npm run lint in the root folder, it will install and link dependencies for you.

You can then run npm run fix.

@donghez-google
Copy link
Contributor Author

@donghez-google it sounds like you're potentially running npm run fix in the wrong folder, I'm guessing you're in ./samples, and you want to run int he top level folder.

If you run npm run lint in the root folder, it will install and link dependencies for you.

You can then run npm run fix.

I ran 'npm run lint' in the root folder but got another error(https://paste.googleplex.com/5000366669168640). I think there's some issues in package.json script, but no idea how to fix it.

samples/analyzeIamPolicy.js Outdated Show resolved Hide resolved
samples/analyzeIamPolicy.js Outdated Show resolved Hide resolved
@bcoe bcoe merged commit dfbd75c into googleapis:master Jan 28, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 9, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [3.12.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.11.0...v3.12.0) (2021-02-09)


### Features

* **samples:** add samples for analyzeIamPolicy and analyzeIamPolicyLongrunning ([#433](https://www.github.com/googleapis/nodejs-asset/issues/433)) ([dfbd75c](https://www.github.com/googleapis/nodejs-asset/commit/dfbd75c98f2977d3a9af06e7637c005b82eda973))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudasset Issues related to the googleapis/nodejs-asset API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants