fix: make request optional in all cases (#467)

Committer: @miraleung PiperOrigin-RevId: 380641501
googleapis · Jun 25, 2021 · 30a0585 · 30a0585
1 parent 301a621
commit 30a0585
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 29 deletions.
diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml
@@ -1,3 +1,3 @@
 docker:
   image: gcr.io/repo-automation-bots/owlbot-nodejs:latest
-  digest: sha256:c9c7828c165b1985579098978877935ee52dda2b1b538087514fd24fa2443e7a
+  digest: sha256:805e2e389eafefa5ed484c30b83a7a875e6b1c7ee125d812e8b01ecc531c3fac
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -24,6 +24,8 @@ jobs:
       - run: rm -rf node_modules
       - run: npm install
       - run: npm test
+        env:
+          MOCHA_THROW_DEPRECATION: false
   windows:
     runs-on: windows-latest
     steps:
@@ -33,6 +35,8 @@ jobs:
           node-version: 14
       - run: npm install
       - run: npm test
+        env:
+          MOCHA_THROW_DEPRECATION: false
   lint:
     runs-on: ubuntu-latest
     steps:

diff --git a/src/v1/data_transfer_service_client.ts b/src/v1/data_transfer_service_client.ts
@@ -351,7 +351,7 @@ export class DataTransferServiceClient {
   // -- Service calls --
   // -------------------
   getDataSource(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IGetDataSourceRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IGetDataSourceRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -405,7 +405,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.getDataSource(request);
    */
   getDataSource(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IGetDataSourceRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IGetDataSourceRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -451,7 +451,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.getDataSource(request, options, callback);
   }
   createTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.ICreateTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.ICreateTransferConfigRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -536,7 +536,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.createTransferConfig(request);
    */
   createTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.ICreateTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.ICreateTransferConfigRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -582,7 +582,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.createTransferConfig(request, options, callback);
   }
   updateTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IUpdateTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IUpdateTransferConfigRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -666,7 +666,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.updateTransferConfig(request);
    */
   updateTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IUpdateTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IUpdateTransferConfigRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -712,7 +712,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.updateTransferConfig(request, options, callback);
   }
   deleteTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferConfigRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -766,7 +766,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.deleteTransferConfig(request);
    */
   deleteTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferConfigRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -812,7 +812,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.deleteTransferConfig(request, options, callback);
   }
   getTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferConfigRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -865,7 +865,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.getTransferConfig(request);
    */
   getTransferConfig(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferConfigRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferConfigRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -911,7 +911,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.getTransferConfig(request, options, callback);
   }
   scheduleTransferRuns(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IScheduleTransferRunsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IScheduleTransferRunsRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -972,9 +972,10 @@ export class DataTransferServiceClient {
    *   for more details and examples.
    * @example
    * const [response] = await client.scheduleTransferRuns(request);
+   * @deprecated ScheduleTransferRuns is deprecated and may be removed in a future version.
    */
   scheduleTransferRuns(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IScheduleTransferRunsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IScheduleTransferRunsRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -1017,10 +1018,15 @@ export class DataTransferServiceClient {
         parent: request.parent || '',
       });
     this.initialize();
+    gax.warn(
+      'DEP$DataTransferService-$ScheduleTransferRuns',
+      'ScheduleTransferRuns is deprecated and may be removed in a future version.',
+      'DeprecationWarning'
+    );
     return this.innerApiCalls.scheduleTransferRuns(request, options, callback);
   }
   startManualTransferRuns(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IStartManualTransferRunsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IStartManualTransferRunsRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1081,7 +1087,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.startManualTransferRuns(request);
    */
   startManualTransferRuns(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IStartManualTransferRunsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IStartManualTransferRunsRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -1131,7 +1137,7 @@ export class DataTransferServiceClient {
     );
   }
   getTransferRun(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferRunRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferRunRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1184,7 +1190,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.getTransferRun(request);
    */
   getTransferRun(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferRunRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IGetTransferRunRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -1230,7 +1236,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.getTransferRun(request, options, callback);
   }
   deleteTransferRun(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferRunRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferRunRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1283,7 +1289,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.deleteTransferRun(request);
    */
   deleteTransferRun(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferRunRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IDeleteTransferRunRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -1329,7 +1335,7 @@ export class DataTransferServiceClient {
     return this.innerApiCalls.deleteTransferRun(request, options, callback);
   }
   checkValidCreds(
-    request: protos.google.cloud.bigquery.datatransfer.v1.ICheckValidCredsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.ICheckValidCredsRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1387,7 +1393,7 @@ export class DataTransferServiceClient {
    * const [response] = await client.checkValidCreds(request);
    */
   checkValidCreds(
-    request: protos.google.cloud.bigquery.datatransfer.v1.ICheckValidCredsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.ICheckValidCredsRequest,
     optionsOrCallback?:
       | CallOptions
       | Callback<
@@ -1434,7 +1440,7 @@ export class DataTransferServiceClient {
   }
 
   listDataSources(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListDataSourcesRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListDataSourcesRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1496,7 +1502,7 @@ export class DataTransferServiceClient {
    *   for more details and examples.
    */
   listDataSources(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListDataSourcesRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListDataSourcesRequest,
     optionsOrCallback?:
       | CallOptions
       | PaginationCallback<
@@ -1644,7 +1650,7 @@ export class DataTransferServiceClient {
     ) as AsyncIterable<protos.google.cloud.bigquery.datatransfer.v1.IDataSource>;
   }
   listTransferConfigs(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListTransferConfigsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListTransferConfigsRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1707,7 +1713,7 @@ export class DataTransferServiceClient {
    *   for more details and examples.
    */
   listTransferConfigs(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListTransferConfigsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListTransferConfigsRequest,
     optionsOrCallback?:
       | CallOptions
       | PaginationCallback<
@@ -1859,7 +1865,7 @@ export class DataTransferServiceClient {
     ) as AsyncIterable<protos.google.cloud.bigquery.datatransfer.v1.ITransferConfig>;
   }
   listTransferRuns(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListTransferRunsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListTransferRunsRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -1925,7 +1931,7 @@ export class DataTransferServiceClient {
    *   for more details and examples.
    */
   listTransferRuns(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListTransferRunsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListTransferRunsRequest,
     optionsOrCallback?:
       | CallOptions
       | PaginationCallback<
@@ -2083,7 +2089,7 @@ export class DataTransferServiceClient {
     ) as AsyncIterable<protos.google.cloud.bigquery.datatransfer.v1.ITransferRun>;
   }
   listTransferLogs(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListTransferLogsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListTransferLogsRequest,
     options?: CallOptions
   ): Promise<
     [
@@ -2147,7 +2153,7 @@ export class DataTransferServiceClient {
    *   for more details and examples.
    */
   listTransferLogs(
-    request: protos.google.cloud.bigquery.datatransfer.v1.IListTransferLogsRequest,
+    request?: protos.google.cloud.bigquery.datatransfer.v1.IListTransferLogsRequest,
     optionsOrCallback?:
       | CallOptions
       | PaginationCallback<