Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): allow for TableSchema to be used #438

Merged
merged 1 commit into from
May 15, 2019
Merged

fix(table): allow for TableSchema to be used #438

merged 1 commit into from
May 15, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 15, 2019

Fixes #435

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #438   +/-   ##
======================================
  Coverage    99.4%   99.4%           
======================================
  Files           4       4           
  Lines         672     672           
  Branches      188     188           
======================================
  Hits          668     668           
  Misses          2       2           
  Partials        2       2
Impacted Files Coverage Δ
src/table.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436e8da...034fed8. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7995be0 into googleapis:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid typings of TableMetadata
3 participants