Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly encode nested struct/array params #439

Merged
merged 2 commits into from
May 15, 2019
Merged

fix: correctly encode nested struct/array params #439

merged 2 commits into from
May 15, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 15, 2019

Fixes #437

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #439 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #439      +/-   ##
=========================================
+ Coverage    99.4%   99.4%   +<.01%     
=========================================
  Files           4       4              
  Lines         672     674       +2     
  Branches      188     189       +1     
=========================================
+ Hits          668     670       +2     
  Misses          2       2              
  Partials        2       2
Impacted Files Coverage Δ
src/index.ts 98.48% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7995be0...ae1c63e. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit d7006bd into googleapis:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parametric Query fails when dealing with repeated records (array of structs)
3 participants