Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): dataset model support #449

Merged
merged 10 commits into from
May 22, 2019
Merged

feat(model): dataset model support #449

merged 10 commits into from
May 22, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented May 21, 2019

This adds Dataset Model support.

@callmehiphop callmehiphop added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2019
@callmehiphop callmehiphop changed the title eat(model): dataset model support feat(model): dataset model support May 21, 2019
@callmehiphop
Copy link
Contributor Author

callmehiphop commented May 21, 2019

@tswast @shollyman I think I have the basic implementation of the CRUD methods complete, but I'm not sure how to test it? I tried reviewing googleapis/google-cloud-python#7562 to see how models are created there, but my python isn't so great that I could figure it out 😢. Any hints here would be greatly appreciated! Found a go example!

@sduskis @JustinBeckwith Should I include samples in this PR? Historically some one else has always written them, but it looks like I can pull the region tags from the PRs in other langs.

@tswast
Copy link
Contributor

tswast commented May 21, 2019

Should I include samples in this PR? Historically some one else has always written them, but it looks like I can pull the region tags from the PRs in other langs.

Either you or @steffnay should write the samples. I think Steffany wanted to focus on Node.js samples this quarter.

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #449 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage    99.4%   99.42%   +0.02%     
==========================================
  Files           4        5       +1     
  Lines         674      699      +25     
  Branches      189      194       +5     
==========================================
+ Hits          670      695      +25     
  Misses          2        2              
  Partials        2        2
Impacted Files Coverage Δ
src/index.ts 98.49% <100%> (+0.01%) ⬆️
src/dataset.ts 100% <100%> (ø) ⬆️
src/model.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f432a0c...6febf18. Read the comment docs.

@callmehiphop callmehiphop removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2019
@callmehiphop callmehiphop marked this pull request as ready for review May 21, 2019 21:27
@steffnay
Copy link
Contributor

This is great. I can do the samples!

@steffnay steffnay merged commit 3ad884f into googleapis:master May 22, 2019
@callmehiphop callmehiphop deleted the models branch May 30, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants