Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): update to the latest discovery types #518

Merged
merged 2 commits into from
Aug 27, 2019
Merged

fix(types): update to the latest discovery types #518

merged 2 commits into from
Aug 27, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Aug 8, 2019

Some of the Model response objects have changed upstream, this is just us generating updated types for the request/response types.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2019
@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #518 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #518   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           5        5           
  Lines         698      698           
  Branches      192      192           
=======================================
  Hits          694      694           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd59a6...a88bcab. Read the comment docs.

@callmehiphop
Copy link
Contributor Author

@bcoe @JustinBeckwith is there anyway we could leverage Kokoro to generate the types for us?

/cc @shollyman

@shollyman
Copy link
Contributor

Is types.d.ts fully autogenerated, or partially? It's not clear from this PR how that happens.

@callmehiphop
Copy link
Contributor Author

@shollyman we have an npm script that generates that file when ran.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 27, 2019
@callmehiphop callmehiphop merged commit dccf2cf into googleapis:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants