Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency discovery-tsd to ^0.2.0 #540

Merged
merged 2 commits into from
Sep 12, 2019
Merged

fix(deps): update dependency discovery-tsd to ^0.2.0 #540

merged 2 commits into from
Sep 12, 2019

Conversation

callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Sep 12, 2019

Closes #539

The most recent version of discovery-tsd alphabetizes the types and their properties. This should be helpful when trying to review diffs now that we're generating types via synthtool.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested a review from a team September 12, 2019 13:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #540 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #540   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           5        5           
  Lines         698      698           
  Branches      192      192           
=======================================
  Hits          694      694           
  Misses          3        3           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f711ed...6e362bb. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 651e870 into googleapis:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants