-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect param type if not in provided types #813
Conversation
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
- Coverage 98.51% 98.51% -0.01%
==========================================
Files 9 9
Lines 6389 6387 -2
Branches 373 373
==========================================
- Hits 6294 6292 -2
Misses 95 95
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A system test could be useful here, too.
Was this actually applied? I'm having an issue right now where it's saying I'm not providing the type for an empty array even though I am and I'm starting to wonder if it's because I'm not providing the type for all the other params too |
Adds ability to detect named parameter type if types were provided for some parameters, but not all.
Fixes #802 🦕