Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect param type if not in provided types #813

Merged
merged 4 commits into from
Jul 16, 2020

Conversation

steffnay
Copy link
Contributor

@steffnay steffnay commented Jul 14, 2020

Adds ability to detect named parameter type if types were provided for some parameters, but not all.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #802 🦕

@steffnay steffnay requested a review from a team July 14, 2020 01:05
@steffnay steffnay requested a review from a team as a code owner July 14, 2020 01:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #813 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   98.51%   98.51%   -0.01%     
==========================================
  Files           9        9              
  Lines        6389     6387       -2     
  Branches      373      373              
==========================================
- Hits         6294     6292       -2     
  Misses         95       95              
Impacted Files Coverage Δ
src/bigquery.ts 99.94% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 270ee6a...55eb8f6. Read the comment docs.

Copy link
Contributor

@stephenplusplus stephenplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A system test could be useful here, too.

@JustinBeckwith JustinBeckwith merged commit 1e5a4cc into googleapis:master Jul 16, 2020
@pdfabbro
Copy link

Was this actually applied? I'm having an issue right now where it's saying I'm not providing the type for an empty array even though I am and I'm starting to wonder if it's because I'm not providing the type for all the other params too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow option to provide only some named parameter types
7 participants