Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update samples and docs to match rubric #374

Merged
merged 2 commits into from
Mar 10, 2019
Merged

fix: update samples and docs to match rubric #374

merged 2 commits into from
Mar 10, 2019

Conversation

JustinBeckwith
Copy link
Contributor

@JustinBeckwith JustinBeckwith commented Mar 10, 2019

So... I made a few mistakes. During the code review of #368, a few things slipped:

  1. Renames the sample files from bigquery_dataset_bleh.js to createDataset.js
  2. Moves the region tags inside of the function definition, to match the rubric
  3. Update cloud-repo-tools.json to include the new samples
  4. Runs the repo-tools generation step to update the documentation

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2019
@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #374 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #374   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files           4        4           
  Lines         544      544           
  Branches       75       75           
=======================================
  Hits          541      541           
  Misses          2        2           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd851f...3beb513. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit b92b75f into googleapis:master Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants