Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update table.js #78

Merged
merged 2 commits into from
Aug 10, 2018
Merged

Update table.js #78

merged 2 commits into from
Aug 10, 2018

Conversation

indatawetrust
Copy link
Contributor

Fixes #77

trim function corrected the error. api gives an error when there is a space.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2396b1c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #78   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      4           
  Lines             ?    713           
  Branches          ?      0           
=======================================
  Hits              ?    713           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/table.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2396b1c...af44acf. Read the comment docs.

@stephenplusplus
Copy link
Contributor

Thank you for this! Could you trim the field name as well, and add a test to test/table.js? :)

@stephenplusplus
Copy link
Contributor

@JustinBeckwith I'll finish this one up real quick.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@stephenplusplus
Copy link
Contributor

Ok, PTAL @JustinBeckwith :)

@JustinBeckwith JustinBeckwith added the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 25, 2018
@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 25, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@JustinBeckwith
Copy link
Contributor

@stephenplusplus this LGTM!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 10, 2018
@stephenplusplus
Copy link
Contributor

@JustinBeckwith I had to do a rebase, and now CLA bot is sad again. Should I ignore it?

@JustinBeckwith JustinBeckwith added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2018
@JustinBeckwith JustinBeckwith removed the cla: no This human has *not* signed the Contributor License Agreement. label Aug 10, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@JustinBeckwith JustinBeckwith merged commit f330015 into googleapis:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants