Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency gts to v1 #407

Merged
merged 5 commits into from
May 3, 2019
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 26, 2019

This PR contains the following updates:

Package Type Update Change References
gts devDependencies major ^0.9.0 -> ^1.0.0 source

Release Notes

google/gts

v1.0.0

Compare Source

This release contains breaking changes. Picking up this update most likely will cause a breaking change in your module. Take care when picking up this update.

Breaking Changes

  • We have switched to prettier as the code formatting tool (#​259). gts run fix should migrate your code over to the new style 💅.
  • This release drops support for Node 6 which will reach end-of-life in April 2019 (#​256) 💀.
  • This release defaults to ES2017 as the TypeScript code generation target. This means that the generated code needs a minimum of Node 8 to run. On the plus side this means that generated code would use native implementation of ES2017 features (e.g. async/await) rather than using poly-fills 🧬. This change is most likely a breaking change for your module. You can override this setting by customizing your tsconfig.json however.
  • The tslint configuration has been updated to pick up changes in the Google style guide🧐.
  • Assumes that target projects are using TypeScript 3.x+ 🎯.

Other features


Renovate configuration

📅 Schedule: "after 9am and before 3pm" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2019
@callmehiphop callmehiphop added automerge Summon MOG for automerging kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2019
@renovate
Copy link
Contributor Author

renovate bot commented Apr 26, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@JustinBeckwith JustinBeckwith added Breaking Change and removed automerge Summon MOG for automerging labels Apr 26, 2019
@callmehiphop
Copy link
Contributor

@JustinBeckwith why does this result in a breaking change? I would think any changes would be purely stylistic.

@JustinBeckwith
Copy link
Contributor

These absolutely are breaking 😄 gts@1.0.0 changes the default target in the tsconfig to es2017, which brings in native async/await. We can't merge these until next week when we drop Node.js 6 from the CI. If the CI for 6 passes with this, we should all be super scared.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 3, 2019
@callmehiphop callmehiphop added automerge Summon MOG for automerging kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #407 into master will increase coverage by 0.02%.
The diff coverage is 98.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #407      +/-   ##
========================================
+ Coverage   97.97%    98%   +0.02%     
========================================
  Files           5      5              
  Lines         396    401       +5     
  Branches       98     99       +1     
========================================
+ Hits          388    393       +5     
  Misses          3      3              
  Partials        5      5
Impacted Files Coverage Δ
src/operation.ts 100% <100%> (ø) ⬆️
src/service-object.ts 99% <100%> (ø) ⬆️
src/index.ts 100% <100%> (ø) ⬆️
src/util.ts 97.5% <100%> (ø) ⬆️
src/service.ts 96.29% <87.5%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9392b...a4041dd. Read the comment docs.

@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 3, 2019
@callmehiphop callmehiphop merged commit 8e73d8c into master May 3, 2019
@renovate renovate bot deleted the renovate/gts-1.x branch May 3, 2019 17:44
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Summon MOG for automerging Breaking Change cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants