-
Notifications
You must be signed in to change notification settings - Fork 113
Adds basic support for InstanceGroupManager #263
Adds basic support for InstanceGroupManager #263
Conversation
- Basic instance support (exists, get, getMetadata, etc). - Supports resize as well.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
CLAs look good, thanks! |
This is ready to be reviewed now. I don't know how to check the status on the automated checks. |
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 99.11% 99.13% +0.02%
==========================================
Files 19 20 +1
Lines 1473 1509 +36
==========================================
+ Hits 1460 1496 +36
Misses 13 13
Continue to review full report at Codecov.
|
This is awesome! |
@JustinBeckwith I think the code coverage should be back up on |
Can I run the ci/kokoro tests locally? |
@JustinBeckwith Docs added for |
Thanks for being patient with this one :) |
Heh, 3 hours on a Sunday is tolerable :P |
Awesome, thanks for the work! |
Basic instance support (exists, get, getMetadata, etc).
Supports resize as well.
Partially addresses Bindings for Instance Group Managers? #103.
Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)