Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Adds basic support for InstanceGroupManager #263

Merged
merged 8 commits into from
Feb 11, 2019

Conversation

modeswitch
Copy link
Contributor

@modeswitch modeswitch commented Feb 10, 2019

  • Basic instance support (exists, get, getMetadata, etc).

  • Supports resize as well.

  • Partially addresses Bindings for Instance Group Managers? #103.

  • Tests and linter pass

  • Code coverage does not decrease (if any source code was changed)

  • Appropriate docs were updated (if necessary)

- Basic instance support (exists, get, getMetadata, etc).
- Supports resize as well.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 10, 2019
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 10, 2019
@modeswitch
Copy link
Contributor Author

This is ready to be reviewed now. I don't know how to check the status on the automated checks.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@codecov
Copy link

codecov bot commented Feb 10, 2019

Codecov Report

Merging #263 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   99.11%   99.13%   +0.02%     
==========================================
  Files          19       20       +1     
  Lines        1473     1509      +36     
==========================================
+ Hits         1460     1496      +36     
  Misses         13       13
Impacted Files Coverage Δ
src/zone.js 100% <100%> (ø) ⬆️
src/instance-group-manager.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b43132...5dd8916. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@JustinBeckwith
Copy link
Contributor

This is awesome!

@modeswitch
Copy link
Contributor Author

@JustinBeckwith I think the code coverage should be back up on zone.js. I'm not sure why the docs links are broken though.

@modeswitch
Copy link
Contributor Author

Can I run the ci/kokoro tests locally?

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 10, 2019
@modeswitch
Copy link
Contributor Author

@JustinBeckwith Docs added for InstanceGroupManager. I think that should fix the last of the CI complaints. Can you re-run kokoro?

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2019
@JustinBeckwith
Copy link
Contributor

Thanks for being patient with this one :)

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2019
@modeswitch
Copy link
Contributor Author

Heh, 3 hours on a Sunday is tolerable :P

@JustinBeckwith JustinBeckwith merged commit 2d9a322 into googleapis:master Feb 11, 2019
@toots
Copy link

toots commented Feb 11, 2019

Awesome, thanks for the work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants