Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: allow pollIntervalMs to be configured #392

Merged
merged 2 commits into from
Jan 23, 2020
Merged

feat: allow pollIntervalMs to be configured #392

merged 2 commits into from
Jan 23, 2020

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jan 23, 2020

Allows pollIntervalMs to be configured for long running operations, when instantiating a Compute instance:

new Compute({
  pollIntervalMs: 2000
})

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2020
@bcoe bcoe requested review from stephenplusplus, JustinBeckwith and alexander-fenster and removed request for stephenplusplus January 23, 2020 19:58
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #392 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #392      +/-   ##
=========================================
+ Coverage    99.8%   99.8%   +<.01%     
=========================================
  Files          20      20              
  Lines       11712   11739      +27     
=========================================
+ Hits        11689   11716      +27     
  Misses         23      23
Impacted Files Coverage Δ
src/instance-group.js 100% <100%> (ø) ⬆️
src/autoscaler.js 100% <100%> (ø) ⬆️
src/network.js 100% <100%> (ø) ⬆️
src/snapshot.js 100% <100%> (ø) ⬆️
src/rule.js 100% <100%> (ø) ⬆️
src/index.js 100% <100%> (ø) ⬆️
src/firewall.js 100% <100%> (ø) ⬆️
src/zone.js 100% <100%> (ø) ⬆️
src/instance-group-manager.js 100% <100%> (ø) ⬆️
src/subnetwork.js 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdc5563...e2f55dc. Read the comment docs.

@bcoe bcoe merged commit 0f9c6eb into master Jan 23, 2020
@stephenplusplus stephenplusplus deleted the poll-interval branch August 10, 2020 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants