Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

build: automate generation and updates with OwlBot #651

Merged
merged 8 commits into from
Dec 8, 2021
Merged

build: automate generation and updates with OwlBot #651

merged 8 commits into from
Dec 8, 2021

Conversation

summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Dec 7, 2021 •
edited
Loading

automate generate nodejs-compute by:

  • Use the latest change compute.proto with fixed IPProtocol enum name conflict issue
  • Config using Owlbot

@summer-ji-eng summer-ji-eng requested review from a team as code owners December 7, 2021 22:31
@product-auto-label product-auto-label bot added the api: compute Issues related to the googleapis/nodejs-compute API. label Dec 7, 2021
@snippet-bot
Copy link

snippet-bot bot commented Dec 7, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 585 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@summer-ji-eng
Copy link
Contributor Author

Modify the eslintignore in synthtool googleapis/synthtool#1302
Otherwise synthtool would overwrite the eslintignore and remove samples/generated/, it cause the linter fails.

@summer-ji-eng summer-ji-eng changed the title test: generated library build: automate generation and updates with OwlBot Dec 8, 2021
alexander-fenster
alexander-fenster approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@alexander-fenster alexander-fenster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (without actually checking) since tests pass. Something wrong with docs tests (linkinator?) though.

@bcoe bcoe merged commit 2b925fa into main Dec 8, 2021
@bcoe bcoe deleted the gcp_preview branch December 8, 2021 22:11
This was referenced Jan 11, 2022
Merged
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

@bcoe bcoe Awaiting requested review from bcoe

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

Assignees
No one assigned
Labels
api: compute Issues related to the googleapis/nodejs-compute API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@summer-ji-eng @alexander-fenster @bcoe