Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable noImplicitAny in the tsconfig #252

Closed
JustinBeckwith opened this issue Nov 16, 2018 · 2 comments · Fixed by #305
Closed

Enable noImplicitAny in the tsconfig #252

JustinBeckwith opened this issue Nov 16, 2018 · 2 comments · Fixed by #305
Assignees
@JustinBeckwith
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. help wanted We'd love to have community involvement on this issue. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. TypeScript

Comments

@JustinBeckwith
Copy link
Contributor

The goal here is to provide perfect TypeScript types for customers using the module. Generally when doing this work I like to:

  1. enable noImplicitAny in the tsconfig
  2. Choose a single file to get passing, and fix all errors in that file (using VSCode here is really useful)
  3. disablenoImplicitAny
  4. Get all the tests passing
  5. Submit a PR for just the single file I updated
  6. Repeat until finished

It's a lot easier if we do a PR per file on this one. 
@JustinBeckwith JustinBeckwith added help wanted We'd love to have community involvement on this issue. TypeScript type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Nov 16, 2018
@muraliQlogic muraliQlogic self-assigned this Dec 10, 2018
@josecervino
Copy link

josecervino commented Dec 28, 2018 •
edited
Loading

@JustinBeckwith it cool if I hop on this/take it off your hands?

@JustinBeckwith
Copy link
Contributor Author

👋 sure! Lets just wait for #291 to land first :)

@josecervino josecervino mentioned this issue Jan 19, 2019
Merged
3 tasks
@google-cloud-label-sync google-cloud-label-sync bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustinBeckwith JustinBeckwith

Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. help wanted We'd love to have community involvement on this issue. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(types): enable noImplicitAny for transaction.ts & request.ts
3 participants
@JustinBeckwith @josecervino @muraliQlogic