Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update retry and timeout logic for generated async/stream #883

Merged
merged 7 commits into from
Oct 13, 2021
Merged

feat: update retry and timeout logic for generated async/stream #883

merged 7 commits into from
Oct 13, 2021

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Oct 12, 2021

  • Regenerate this pull request now.

PiperOrigin-RevId: 402634944

Source-Link: googleapis/googleapis@29de512

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2a306fa9cd7735704235713cca1cf926419847d6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmEzMDZmYTljZDc3MzU3MDQyMzU3MTNjY2ExY2Y5MjY0MTk4NDdkNiJ9

@gcf-owl-bot
build: update package name for datastore
251887d 
PiperOrigin-RevId: 402634944

Source-Link: googleapis/googleapis@29de512

Source-Link: googleapis/googleapis-gen@2a306fa
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmEzMDZmYTljZDc3MzU3MDQyMzU3MTNjY2ExY2Y5MjY0MTk4NDdkNiJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 12, 2021 21:47
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 12, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Oct 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 12, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 12, 2021 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 12, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2021
@JustinBeckwith JustinBeckwith added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2021
JustinBeckwith
JustinBeckwith suggested changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sofisl do we have a way to disable snippet gen for hand written libraries?

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@bcoe
Copy link
Contributor

bcoe commented Oct 13, 2021

@JustinBeckwith in this case, we do actually export the gapic library as v1, wondering if there's any reason not to have the generated samples -- for folks who happen to run it directly.

@JustinBeckwith
Copy link
Contributor

Let's loop in @crwilcox and @kolea2 to make a call here.

@crwilcox
Copy link
Contributor

The PR title seems rather off to me. Is this adding generated samples?

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 13, 2021
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot removed the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 13, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 13, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@google-cla
Copy link

google-cla bot commented Oct 13, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@bcoe bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 13, 2021
@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 13, 2021
@bcoe bcoe changed the title build: update package name for datastore build: generator adds support for defaultCallSettings Oct 13, 2021
@bcoe bcoe changed the title build: generator adds support for defaultCallSettings feat: update retry and timeout logic for generated async/stream Oct 13, 2021
@bcoe bcoe removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 13, 2021
@bcoe bcoe merged commit cd3ae5c into main Oct 13, 2021
@bcoe bcoe deleted the owl-bot-e9f43d08-cf1a-430f-b772-60fff10e2d3a branch October 13, 2021 22:26
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 13, 2021
@release-please
chore: release 6.6.0 (#884)
918ace7 
🤖 I have created a release \*beep\* \*boop\*
---
## [6.6.0](https://www.github.com/googleapis/nodejs-datastore/compare/v6.5.0...v6.6.0) (2021-10-13)


### Features

* update retry and timeout logic for generated async/stream ([#883](https://www.github.com/googleapis/nodejs-datastore/issues/883)) ([cd3ae5c](https://www.github.com/googleapis/nodejs-datastore/commit/cd3ae5c12eddac3cc1149308c96cf9a8b0265e21))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. cla: yes This human has signed the Contributor License Agreement. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bcoe @JustinBeckwith @crwilcox @yoshi-kokoro