Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only try to authenticate if reporting is enabled. #550

Closed
rhodgkins opened this issue Mar 31, 2021 · 3 comments · Fixed by #676
Closed

Only try to authenticate if reporting is enabled. #550

rhodgkins opened this issue Mar 31, 2021 · 3 comments · Fixed by #676
Assignees
@losalex
Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@rhodgkins
Copy link

When running this package locally with reportMode: 'never' which prevents any reporting but we still get an console message about not being able to find credential information because when creating the error reporting client authentication is still attempted.

Would it be possible for a similar check be put in before attempting this (both API key and obtaining an access token)?
@product-auto-label product-auto-label bot added the api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. label Mar 31, 2021
@keenan-devrel keenan-devrel added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 31, 2021
@simonz130 simonz130 assigned freelerobot and unassigned simonz130 Apr 5, 2021
@freelerobot
Copy link
Contributor

This is a really good suggestion & I dont see tradeoffs off the bat. We should add it to this library & short-circuit auth in this case.

@freelerobot freelerobot assigned simonz130 and unassigned freelerobot Jun 29, 2021
@spaghettiguru
Copy link

any progress with this?

@simonz130 simonz130 assigned losalex and unassigned simonz130 Feb 14, 2022
@minherz minherz added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 13, 2022
@filipecatraia
Copy link

filipecatraia commented Sep 13, 2022 •
edited
Loading

Hey APIs team, it's been a long time without this and #460 :)

@comp615 comp615 mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@losalex losalex

Labels
api: clouderrorreporting Issues related to the googleapis/nodejs-error-reporting API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: do not try and authenticate when error reporting is disabled comp615/nodejs-error-reporting
8 participants
@rhodgkins @minherz @spaghettiguru @filipecatraia @simonz130 @keenan-devrel @freelerobot @losalex