fix: Don't re-open streams on 'error' and 'end' #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt/parralelerrors
branch
from
c0c9d1b
to
6ff2756
Compare
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 96.21% 96.05% -0.17%
==========================================
Files 20 20
Lines 2220 2228 +8
Branches 470 472 +2
==========================================
+ Hits 2136 2140 +4
- Misses 20 22 +2
- Partials 64 66 +2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #713 +/- ##
==========================================
- Coverage 96.21% 96.05% -0.17%
==========================================
Files 20 20
Lines 2220 2228 +8
Branches 470 472 +2
==========================================
+ Hits 2136 2140 +4
- Misses 20 22 +2
- Partials 64 66 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From scrubbing through the logs at firebase/firebase-admin-node#585 it seems like we can get into a weird loop when
maybeReopenStreamgets called by both theendanderrorhandler, resulting in exponentially increasing calls tobackoffAndWait(). This can then cause the backoff handler to error on a single network glitch.