Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrying 13 INTERNAL RPC errors #742

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

Retrying INTERNAL errors for Idempotent calls should help address firebase/firebase-functions#536

Retrying INTERNAL errors for Idempotent calls should help address firebase/firebase-functions#536
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2019
@codecov
Copy link

codecov bot commented Aug 30, 2019

Codecov Report

Merging #742 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #742   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files          20       20           
  Lines        2236     2236           
  Branches      467      467           
=======================================
  Hits         2157     2157           
  Misses         24       24           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32cffcc...a22ac24. Read the comment docs.

@alexander-fenster
Copy link
Contributor

@schmidt-sebastian Note that this file is auto-generated. It's OK to try this change here to see if it helps, but the ground truth is https://github.com/googleapis/googleapis/blob/82809578652607c8ee29d9e199c21f28f81a03e0/google/firestore/v1/firestore_gapic.yaml#L41-L42 (and it, in turn, gets auto-synced from third_party internal folder, which is the real place where this change must be done).

@alexander-fenster
Copy link
Contributor

(what I mean is that the change made here will disappear after synthtool run - I'm approving it if you'd like to test it out here fast, but we won't see it here for long :) )

@schmidt-sebastian
Copy link
Contributor Author

@schmidt-sebastian Note that this file is auto-generated. It's OK to try this change here to see if it helps, but the ground truth is https://github.com/googleapis/googleapis/blob/82809578652607c8ee29d9e199c21f28f81a03e0/google/firestore/v1/firestore_gapic.yaml#L41-L42 (and it, in turn, gets auto-synced from third_party internal folder, which is the real place where this change must be done).

Which, in turn, is generated from https://cs.corp.google.com/piper///depot/google3/google/firestore/admin/v1/firestore_gapic.yaml :)
I will commit this and release this ASAP. Changing the main GAPIC file has to be coordinated with the backend, which I will take care of after.

@schmidt-sebastian schmidt-sebastian merged commit 431edcb into master Aug 30, 2019
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-2 branch January 3, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants