fix: collectionReference.add() validation #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
added
the
api: firestore
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #925 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 25 25
Lines 15639 15639
Branches 1164 1164
=======================================
Hits 15105 15105
Misses 525 525
Partials 9 9Continue to review full report at Codecov.
|
thebrianchen
changed the title
schmidt-sebastian
suggested changes
Feb 18, 2020
schmidt-sebastian
approved these changes
Feb 18, 2020
dev/test/collection.ts
Outdated
| commit: request => { | ||
| docId = request.writes![0].update!.name!; | ||
| // Remove the auto-generated id and then verify that the rest of the | ||
| // protobuf matches. |
There was a problem hiding this comment.
Oh, wow. Good fix for this issue that I definitely didn't see coming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #924
Needed to convert data toFirestore first before performing validation. Also modified system test to use
CollectionReference.add().