Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: add serverCertFile parameter #438

Merged
merged 4 commits into from
Feb 10, 2021
Merged

feat: add serverCertFile parameter #438

merged 4 commits into from
Feb 10, 2021

Conversation

gcseh
Copy link
Contributor

@gcseh gcseh commented Feb 9, 2021

Fixes issue #422

@product-auto-label product-auto-label bot added the api: cloudiot Issues related to the googleapis/nodejs-iot API. label Feb 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 9, 2021
@gcseh gcseh requested a review from telpirion February 9, 2021 11:06
@gcseh gcseh linked an issue Feb 9, 2021 that may be closed by this pull request
Use the server certificate in the NodeJS example #422
Closed
@gcseh gcseh changed the title add serverCertFile parameter feat: add serverCertFile parameter Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021 •
edited
Loading

Codecov Report

Merging #438 (af40a4f) into master (cb2c949) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files           5        5           
  Lines        2683     2683           
  Branches      105      105           
=======================================
  Hits         2612     2612           
  Misses         70       70           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2c949...b723624. Read the comment docs.

@gcseh gcseh added the samples Issues that are directly related to samples. label Feb 9, 2021
telpirion
telpirion approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one very small nit.

samples/mqtt_example/test/cloudiot_mqtt_example.test.js Show resolved Hide resolved
@gcseh gcseh marked this pull request as ready for review February 10, 2021 11:19
@gcseh gcseh requested a review from a team as a code owner February 10, 2021 11:19
@gcseh gcseh merged commit e979160 into master Feb 10, 2021
@gcseh gcseh deleted the add-server-cert branch February 10, 2021 11:27
This was referenced Feb 10, 2021
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@telpirion telpirion telpirion approved these changes

Assignees
No one assigned
Labels
api: cloudiot Issues related to the googleapis/nodejs-iot API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the server certificate in the NodeJS example
2 participants
@gcseh @telpirion